Always refer to "finally" tasks 📖

[bobcatfish]

Changes

This commit changes all references to "final tasks" to "finally tasks".
We were using a mix of "final tasks" and "finally tasks" to refer to
these tasks, so this commit is making us consistently use one version.
However "finally tasks" is less grammatically correct that "final tasks"
because finally is an adverb - "finally tasks" only makes sense if
"finally tasks" is considered short for "finally tasks in a pipeline".
Another option sould be to go the other way and always use "final tasks"
(and never say "finally tasks"). However if we do this, @Srivaralakshmi
pointed out in #4086 that
this may make it confusing in that reading something like 'the final tasks'
may make a user expect to see a seciton in the pipeline called final
instead of the actual section finally.

We have another option which is to consider finally- an adverb - a
bad name for that section of the Pipeline spec and change it to final.
My understanding of the syntax is a bit different, e.g.:

spec:
  tasks:
    - name: tests
      taskRef:
        name: integration-test
  final:
    - name: cleanup-test
      taskRef:
        name: cleanup

However that would be a big change (tho pre-v1 would be
the time to do it!) and finally is consistent with how this kind of
functionality is expressed in languages like Python.

(Also I understand the finally section to be saying: once all of the above is
done, finally run clean-test, and not to say "cleanup-test is a finally
kind of task". )

The last option would be to support both final and finally but that
feels to me like it would be even more confusing.

/kind documentation

Question for the reviewers: which approach do you think we should take:

1. This one
2. Rename uses of "finally tasks" to "final tasks" (i.e. dont try to force using an adverb as an adjective)
3. Rename the "finally" section to "final"
4. Support both "finally" and "final" in the pipeline spec
5. Something else?

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• [n/a] Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

[bobcatfish]

After writing this out im kinda leaning toward (2) instead - always saying "final" tasks, i.e. "final tasks" are tasks in the "finally section", but it seems like that might increase the confusion that @Srivaralakshmi was describing 🤔

/hold

[ghost]

I lean towards (1), the change you've made. For the following reasons:

• It's the field name we've already got. While language is important I don't see a reason compelling enough to lean towards "final tasks" in our docs, support both "final" and "finally" in our yamls or push users through a painful field renaming.
• "finally" might be an adverb but I've gotten pretty comfortable thinking of them as "Finally Tasks". A Proper Noun. In other words I now think of Finally Tasks as a specific named feature of Tekton Pipelines.
• "Final tasks" is so ambiguous as to be effectively meaningless - I feel like use of this phrase in conversation or writing will always need clarifying clauses to specify author's intent. "Finally tasks" is unambiguous as to its meaning (once you know the features of tekton pipelines).

I realize these are all quite personal opinions, and informed by experience with the project rather than new user glasses. My 2 cents.

[ghost]

/approve

[bobcatfish]

I've made one more tweak which might help: instead of saying "finally tasks" i've added code block markup: finally tasks - which might help make it a bit more clear that finally here is referring to a symbol in the pipeline spec vs trying to act as an adverb

[jerop]

there are several spots with ``finally task instead of `finally` tasks

that is, there's double code markup -- around "finally" and around "finally tasks"

otherwise looks great 👍🏾

[vdemeester]

Agreeing on (1) too 👼🏼

[bobcatfish]

/hold cancel

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jerop, sbwsg, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jerop,sbwsg,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jerop]

/lgtm

[jerop]

fixes #4086

[pritidesai]

thanks a bunch @bobcatfish for making it read better 😸