Loosen permission checks on TestCp to handle umasks. #4100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
System umasks can futher restrict permissions passed to os.OpenFile, resulting in a file that's more restricted than the permission value we supplied. Instead of trying to match the permissions exactly, this change modifies the check to make sure that the new file does not exceed the expected permissions, but allows anything more restrictive.
tekton-robot
added
release-note
|
/kind bug |
|
/test pull-tekton-pipeline-alpha-integration-tests |
ghost
approved these changes
Jul 15, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbwsg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
👍 nice /test pull-tekton-pipeline-alpha-integration-tests |
|
thank you @wlynch sounds good 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
System umasks can futher restrict permissions passed to os.OpenFile,
resulting in a file that's more restricted than the permission value we
supplied. Instead of trying to match the permissions exactly, this
change modifies the check to make sure that the new file does not exceed
the expected permissions, but allows anything more restrictive.
Fixes #4099
/kind bug
/cc @sbwsg
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes