-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to latest knative.dev/pkg #4129
Conversation
/kind cleanup |
Need to run codegen, but I want one more change in PKG to avoid |
For the |
6af37f2
to
ff5bf50
Compare
ff5bf50
to
8fbd17d
Compare
8fbd17d
to
c30f0f8
Compare
For the namespace RBAC changes, the OwnerRef logic was added here: knative/pkg#2098 |
Ok, this seems to be passing tests, but some of the checks need a kick. |
/test check-pr-has-kind-label |
/test .* |
@vdemeester any idea how to kick the CLA bot? For context, this is mostly to land: #4131. |
A good old close/reopen should do the trick (although it restarts all jobs 😹 ) |
/test pull-tekton-pipeline-alpha-integration-tests |
Ok this should be RFAL. Looks like we both did the close/open 😅 |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: imjasonh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
flagging that this change bumps the min k8s version to 1.19 so we need to add release notes for this (got some related errors developing on main) - bump in knative happened in knative/pkg#2157 cc @sbwsg (release captain for v0.27) |
Also this means we will release 0.27 based on a non released version of knative/pkg. Probably not a big deal 😇 |
Changes
This is largely
go get knative.dev/pkg@main
and some changes to fix upstream breakages.Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes