Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest knative.dev/pkg #4129

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

mattmoor
Copy link
Member

@mattmoor mattmoor commented Jul 30, 2021

Changes

This is largely go get knative.dev/pkg@main and some changes to fix upstream breakages.

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Minimum Kubernetes version is now 1.19.

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jul 30, 2021
@tekton-robot tekton-robot requested review from imjasonh and jerop July 30, 2021 16:06
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 30, 2021
@mattmoor
Copy link
Member Author

/kind cleanup

@tekton-robot tekton-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 30, 2021
@mattmoor
Copy link
Member Author

Need to run codegen, but I want one more change in PKG to avoid InternalError events when we use NewRequeue* methods. 😅

@mattmoor
Copy link
Member Author

For the test.KubeClient changes, that was dropped here: knative/pkg#2151

@mattmoor mattmoor force-pushed the update-pkg-2021-07-30 branch from 6af37f2 to ff5bf50 Compare July 30, 2021 17:28
@mattmoor mattmoor mentioned this pull request Jul 30, 2021
5 tasks
@mattmoor mattmoor force-pushed the update-pkg-2021-07-30 branch from ff5bf50 to 8fbd17d Compare July 30, 2021 17:45
@mattmoor mattmoor force-pushed the update-pkg-2021-07-30 branch from 8fbd17d to c30f0f8 Compare July 30, 2021 19:08
@mattmoor
Copy link
Member Author

For the namespace RBAC changes, the OwnerRef logic was added here: knative/pkg#2098

@mattmoor
Copy link
Member Author

Ok, this seems to be passing tests, but some of the checks need a kick.

@mattmoor
Copy link
Member Author

mattmoor commented Aug 2, 2021

/test check-pr-has-kind-label

@vdemeester
Copy link
Member

/test .*

@mattmoor
Copy link
Member Author

mattmoor commented Aug 2, 2021

@vdemeester any idea how to kick the CLA bot?

For context, this is mostly to land: #4131.

@vdemeester vdemeester closed this Aug 2, 2021
@vdemeester vdemeester reopened this Aug 2, 2021
@vdemeester
Copy link
Member

A good old close/reopen should do the trick (although it restarts all jobs 😹 )

@mattmoor mattmoor closed this Aug 2, 2021
@mattmoor mattmoor reopened this Aug 2, 2021
@mattmoor
Copy link
Member Author

mattmoor commented Aug 2, 2021

/test pull-tekton-pipeline-alpha-integration-tests

@mattmoor
Copy link
Member Author

mattmoor commented Aug 4, 2021

Ok this should be RFAL. Looks like we both did the close/open 😅

@imjasonh
Copy link
Member

imjasonh commented Aug 6, 2021

/lgtm
/approve

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2021
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: imjasonh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2021
@tekton-robot tekton-robot merged commit 9d74f3f into tektoncd:main Aug 6, 2021
@mattmoor mattmoor deleted the update-pkg-2021-07-30 branch August 6, 2021 16:31
@jerop
Copy link
Member

jerop commented Aug 9, 2021

flagging that this change bumps the min k8s version to 1.19 so we need to add release notes for this (got some related errors developing on main) - bump in knative happened in knative/pkg#2157

cc @sbwsg (release captain for v0.27)

@vdemeester
Copy link
Member

Also this means we will release 0.27 based on a non released version of knative/pkg. Probably not a big deal 😇

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesnt merit a release note. labels Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants