Remove the gosec Makefile target.

[dlorenc]

Changes

This is not managed by golangci-lint, which does it's own verisoning. The
version in golangci-lint likely won't match this version, so they're most likely
mismatched anyway.

Given that this Makefile target isn't used, we should drop it in favor of make golangci-lint
for consistency.

Signed-off-by: Dan Lorenc [email protected]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

• Docs included if any changes are user facing
• Tests included if any functionality added or changed
• Follows the commit message standard
• Meets the Tekton contributor standards (including
  functionality, content, code)
• Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

[dlorenc]

/kind cleanup

[mattmoor]

/lgtm

[vdemeester]

This is not managed by golangci-lint, which does it's own verisoning. The
version in golangci-lint likely won't match this version, so they're most likely
mismatched anyway.

Given that this Makefile target isn't used, we should drop it in favor of make golangci-lint
for consistency.

So quick note, Makefile is not used anywhere in the CI (yet ? 😛). This would be true for other checks target that are in the Makefile (notably errcheck).

Those were added at a time where they weren't enabled in the golangci-lint configuration, so that a developer could run a one-sot on it's own, or in the case of gosec, to run them on _test.go even if they are disabled by teh golangci-lint configuration.

For me, golangci-lint is made to make sure we can run the same set of checks on the CI and locally. Even though this is not even guaranteed to be true as, golangci-lint version here and on the CI might differ 🙃. But anyway, in my opinion, nothing should prevent us to add more checks on the Makefile (or as scripts, …) for the developers.

[dlorenc]

So quick note, Makefile is not used anywhere in the CI (yet ? 😛). This would be true for other checks target that are in the Makefile (notably errcheck).

Yep, I was using this to test out golangci-lint updates locally before they make their way through plumbing and into CI. It's nice to be able to change this somewhat independently. The gosec one confused me because it was already out of sync with the one in golangci-lint, so I was seeing different output.

[vdemeester]

/approve

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattmoor, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dlorenc]

Rebased, needs another LGTM.

[afrittoli]

/lgtm