-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump github.com/cloudevents/sdk-go to v2.5.0 #4216
Conversation
cc @n3wscott to double check the test change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sorry, there was a string change in the sdk around 2.2
@n3wscott: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks like you need to run |
This updates the cloudevents dependency from v2.1.0 to v2.5.0. This is over a year old and catches us up quite far. There was one manual change in the cloud_event_controller_test.go file. CloudEvents changed the string representation of an event, which our tests looked for. This matches the change to their upstream test: github.com/cloudevents/sdk-go/pull/639. Signed-off-by: Dan Lorenc <[email protected]> Signed-off-by: Dan Lorenc <[email protected]>
/test pull-tekton-pipeline-alpha-integration-tests |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test check-pr-has-kind-label |
/lgtm |
Changes
This updates the cloudevents dependency from v2.1.0 to v2.5.0. This is over a year
old and catches us up quite far.
There was one manual change in the cloud_event_controller_test.go file. CloudEvents
changed the string representation of an event, which our tests looked for. This
matches the change to their upstream test: github.com/cloudevents/sdk-go/pull/639.
Signed-off-by: Dan Lorenc [email protected]
/kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes