Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skipping the CI secret sauce 🦕 #4221

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Skipping the CI secret sauce 🦕 #4221

merged 1 commit into from
Sep 8, 2021

Conversation

vdemeester
Copy link
Member

@vdemeester vdemeester commented Sep 8, 2021 •
edited
Loading

Changes

This is related to #4220. Not fixing it but skipping the problematic tests for now to unblock the CI for the rest of contributors while we fix it.

/hold

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesnt merit a release note. labels Sep 8, 2021
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Sep 8, 2021
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 8, 2021
@vdemeester
Copy link
Member Author

/area test
This is related to #4220. Not fixing it but skipping the problematic tests for now to unblock the CI for the rest of contributors while we fix it.

@vdemeester vdemeester added the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Sep 8, 2021
@vdemeester vdemeester changed the title The CI secret sauce 🦕 Skipping the CI secret sauce 🦕 Sep 8, 2021
chmouel
chmouel reviewed Sep 8, 2021
View reviewed changes
examples/v1beta1/taskruns/foo.yaml Outdated
@@ -0,0 +1,61 @@
---
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you want to commit this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oups..

@chmouel
Copy link
Member

chmouel commented Sep 8, 2021

i think you commited extra files

@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 8, 2021
@chmouel
Copy link
Member

chmouel commented Sep 8, 2021

/lgtm

Looking Good! 🚀

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@vdemeester
Copy link
Member Author

/test pr-has-kind-label

@vdemeester
Skipping the CI secret sauce 🦕
309fd47 
This is skipping tests that depends on the build-crd GCP project that
got deleted recently. This will unblock CI while we replace this with
using our own GCP project (or a better way)

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
@vdemeester
Copy link
Member Author

/hold cancel

@tekton-robot tekton-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Sep 8, 2021
@vdemeester vdemeester added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. labels Sep 8, 2021
@afrittoli
Copy link
Member

The kind/failing-test label is not known by the CI job, since it's not configured as a valid label, which is why the CI job fails:

afrittoli
afrittoli reviewed Sep 8, 2021
View reviewed changes
internal/builder/v1beta1/pod.go
@@ -12,6 +12,7 @@ distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this added by accident?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah that was to make sure it failed before.. so.. yes and no 😛 I can revert 😬

@vdemeester vdemeester removed the kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. label Sep 8, 2021
@vdemeester vdemeester added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Sep 8, 2021
@chmouel
Copy link
Member

chmouel commented Sep 8, 2021

/lgtm

Looking Good! 🤙🏽

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 8, 2021
afrittoli
afrittoli reviewed Sep 8, 2021
View reviewed changes
Copy link
Member

@afrittoli afrittoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could close #4220 and we could have another issue about restoring the disabled tests, but it's also ok to continue on #4220

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 8, 2021
@tekton-robot tekton-robot merged commit 2b6c6a0 into tektoncd:main Sep 8, 2021
@vdemeester vdemeester deleted the ci-secret-sauce branch September 8, 2021 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@chmouel chmouel chmouel left review comments

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@chmouel chmouel

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vdemeester @chmouel @afrittoli @tekton-robot