Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Concurrency issue in the metrics #4222

Merged
merged 1 commit into from
Sep 13, 2021
Merged

Fix Concurrency issue in the metrics #4222

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions pkg/pipelinerunmetrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,9 +281,6 @@ func (r *Recorder) RunningPipelineRuns(lister listers.PipelineRunLister) error {
// ReportRunningPipelineRuns invokes RunningPipelineRuns on our configured PeriodSeconds
// until the context is cancelled.
func (r *Recorder) ReportRunningPipelineRuns(ctx context.Context, lister listers.PipelineRunLister) {
r.mutex.Lock()
r.mutex.Unlock()

logger := logging.FromContext(ctx)

for {
Expand Down
3 changes: 0 additions & 3 deletions pkg/taskrunmetrics/metrics.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -367,9 +367,6 @@ func (r *Recorder) RunningTaskRuns(lister listers.TaskRunLister) error {
// ReportRunningTaskRuns invokes RunningTaskRuns on our configured PeriodSeconds
// until the context is cancelled.
func (r *Recorder) ReportRunningTaskRuns(ctx context.Context, lister listers.TaskRunLister) {
r.mutex.Lock()
defer r.mutex.Unlock()

logger := logging.FromContext(ctx)
for {
select {
Expand Down