Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamp Tekton developer docs for /tekton paths. #4238

Merged
merged 1 commit into from
Sep 17, 2021

Conversation

wlynch
Copy link
Member

@wlynch wlynch commented Sep 16, 2021

Changes

The content is largely the same, this just reorganizes some of the
content into a table and provides a sample filetree to show what
files/directories are present.

Additionally, this adds docs for the following directories that were missing:

  • /tekton/downward
  • /tekton/creds

Other diffs are formatting caused by prettier --prose-wrap always

/kind docs

/cc @bobcatfish

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • [-] Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Sep 16, 2021
@wlynch
Copy link
Member Author

wlynch commented Sep 16, 2021

/release-note-none

@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Sep 16, 2021
@wlynch
Copy link
Member Author

wlynch commented Sep 16, 2021

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Sep 16, 2021
|-- termination
`-- tools
|-- 0
`-- entrypoint
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these backticks part of the directory layout? https://github.com/tektoncd/pipeline/blob/e084563cfc926418b7211f9388857bbbf26e8bf2/docs/developers/README.md#tekton

@sbwsg has explained some of the layout and files in a video here. While we are revamping the developers doc, can we include a link to the video recording?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these backticks part of the directory layout?

The backticks are the formatting of tree as the opposite of / to show that the end of the directory. My guess is was a style choice since `- matches the horizontal line height instead of \-

@sbwsg has explained some of the layout and files in a video here. While we are revamping the developers doc, can we include a link to the video recording?

There's a few useful videos there, so added a link to the top of the page!

The content is largely the same, this just reorganizes some of the
content into a table and provides a sample filetree to show what
files/directories are present.

Additionally, this adds docs for the following directories that were not
already present:

  - /tekton/downward
  - /tekton/creds

Other diffs are formating caused by `prettier --prose-wrap always`
@@ -3,6 +3,10 @@
This document is aimed at helping maintainers/developers of project understand
the complexity.

We also recommend checking out the
[Teknical Tekton](https://www.youtube.com/channel/UCUEuKDqyRnGFCE7FpainSpQ)
channel for training and tutorials on Tekton!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Member

@pritidesai pritidesai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a bunch @wlynch 🎉

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pritidesai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2021
@dlorenc
Copy link
Contributor

dlorenc commented Sep 17, 2021

Thanks! This is much clearer.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 17, 2021
@tekton-robot tekton-robot merged commit 69edb2a into tektoncd:main Sep 17, 2021
@lbernick lbernick mentioned this pull request Jun 17, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/documentation Categorizes issue or PR as related to documentation. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants