Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promoting onError to beta 🎓 #4251

Merged
merged 1 commit into from
Oct 15, 2021
Merged

Promoting onError to beta 🎓 #4251

merged 1 commit into from
Oct 15, 2021

Conversation

pritidesai
Copy link
Member

Changes

Pipeline 0.27 was released in August 2021 which introduced an alpha feature to specify onError in a step. This feature was implemented in the PR #4106.

To enable this feature, the Tekton Pipeline deployment had to set enable-api-fields to alpha.

After discussing this in the API WG:
https://docs.google.com/document/d/17PodAxG8hV351fBhSu7Y_OIPhGTVgj6OJ2lPphYYRpU/edit#heading=h.ig94pf1w10xc
I have sent an email out to collect the feedback from the users. @skaegi is looking forward to this promotion.

Following the promotion guidelines, this commit includes:

  • Updating task validation to no longer require enable-api-fields set to alpha.
  • The documentation is updated to move it out of the alpha section.
  • Moved the example yamls out of alpha.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in or deleted (only if no user facing changes)

Release Notes

Announcement: onError in a step is now stable and available to include in your task definition without any flag.

@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Sep 21, 2021
@tekton-robot tekton-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 21, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_validation.go 97.1% 97.1% -0.0

@pritidesai pritidesai force-pushed the promote-onerror-to-beta branch from c6f1322 to 7bfe6a5 Compare September 21, 2021 19:01
@tekton-robot tekton-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Sep 21, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_validation.go 97.1% 97.1% -0.0

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 27, 2021
@pritidesai
Promoting onError to beta
f601c18 
Pipeline 0.27 was released in August 2021 which introduced an alpha feature to
specify onError in a step. This feature was implemented in the PR tektoncd#4106:
tektoncd#4106

To enable this feature, the Tekton Pipeline deployment had to set
enable-api-fields to alpha.

After discussing this in the API WG:
https://docs.google.com/document/d/17PodAxG8hV351fBhSu7Y_OIPhGTVgj6OJ2lPphYYRpU/edit#heading=h.ig94pf1w10xc
We have sent an email out to collect the feedback from the users.  @skaegi is
looking forward to this promotion.

This commit is updating task validation to no longer require enable-api-fields
is set to alpha.
The documentation is updated to moved it out of the alpha section.
The example yamls moved out of alpha.
Updated e2e to not include alpha flag.
@pritidesai pritidesai force-pushed the promote-onerror-to-beta branch from 7bfe6a5 to f601c18 Compare September 28, 2021 16:32
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2021
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/task_validation.go 97.1% 97.1% -0.0

@pritidesai pritidesai mentioned this pull request Sep 28, 2021
Merged
5 tasks
@pritidesai
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

@pritidesai pritidesai added this to the Pipelines v0.29 milestone Oct 5, 2021
@bobcatfish
Copy link
Collaborator

Sounds good to me!!

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 13, 2021
jerop
jerop reviewed Oct 14, 2021
View reviewed changes
Copy link
Member

@jerop jerop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @pritidesai 🎉

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2021
@jerop
Copy link
Member

jerop commented Oct 14, 2021 •
edited
Loading

/test tekton-pipeline-unit-tests

event_test.go:243: received no events for with sink but (?s)dev.tekton.event.pipelinerun.started.v1.*test1 expected

@jerop
Copy link
Member

jerop commented Oct 15, 2021

dropping lgtm to unblock tide

/lgtm cancel

@tekton-robot tekton-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2021
@jerop
Copy link
Member

jerop commented Oct 15, 2021

re-lgtming now that tide is unblocked and other prs have merged

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 15, 2021
@tekton-robot tekton-robot merged commit e31e4c3 into tektoncd:main Oct 15, 2021
@solsson solsson mentioned this pull request Nov 4, 2021
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerop jerop jerop left review comments

@afrittoli afrittoli Awaiting requested review from afrittoli

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@jerop jerop

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
Pipelines v0.29
Development

Successfully merging this pull request may close these issues.
4 participants
@pritidesai @tekton-robot @bobcatfish @jerop