From 5543283b7d321e92b7bf457f56a80767b616180d Mon Sep 17 00:00:00 2001 From: naosekine <86034003+naosekine@users.noreply.github.com> Date: Fri, 24 Sep 2021 17:02:25 +0900 Subject: [PATCH 1/2] fix a few links in the development file under ... fix a few links in the development file under adding New CRD types --- DEVELOPMENT.md | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index a60a28d9c24..3c72bf057e5 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -471,14 +471,14 @@ If you need to add a new CRD type, you will need to add: - [clusterrole-aggregate-edit.yaml](./config/clusterrole-aggregate-edit.yaml) - [clusterrole-aggregate-view.yaml](./config/clusterrole-aggregate-view.yaml) 1. Add go structs for the types in - [pkg/apis/pipeline/v1alpha1](./pkg/apis/pipeline/v1alpha1) e.g - [condition_types.go](./pkg/apis/pipeline/v1alpha1/condition_types.go) This + [pkg/apis/pipeline/v1beta1](./pkg/apis/pipeline/v1beta1) e.g + [condition_types.go](./pkg/apis/pipeline/v1beta1/condition_types.go) This should implement the - [Defaultable](./pkg/apis/pipeline/v1alpha1/condition_defaults.go) and - [Validatable](./pkg/apis/pipeline/v1alpha1/condition_validation.go) + [Defaultable](./pkg/apis/pipeline/v1beta1/condition_defaults.go) and + [Validatable](./pkg/apis/pipeline/v1beta1/condition_validation.go) interfaces as they are needed for the webhook in the next step. 1. Register it with the [webhook](./cmd/webhook/main.go) 1. Add the new type to the - [list of known types](./pkg/apis/pipeline/v1alpha1/register.go) + [list of known types](./pkg/apis/pipeline/v1beta1/register.go) _See [the API compatibility policy](api_compatibility_policy.md)._ From f71a32c42e5a1f1da6832caa1a4eadfa045cb103 Mon Sep 17 00:00:00 2001 From: naosekine <86034003+naosekine@users.noreply.github.com> Date: Sat, 25 Sep 2021 11:12:03 +0900 Subject: [PATCH 2/2] Update DEVELOPMENT.md with a few links change Update DEVELOPMENT.md with a few links change --- DEVELOPMENT.md | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/DEVELOPMENT.md b/DEVELOPMENT.md index 3c72bf057e5..683961eab2e 100644 --- a/DEVELOPMENT.md +++ b/DEVELOPMENT.md @@ -472,10 +472,10 @@ If you need to add a new CRD type, you will need to add: - [clusterrole-aggregate-view.yaml](./config/clusterrole-aggregate-view.yaml) 1. Add go structs for the types in [pkg/apis/pipeline/v1beta1](./pkg/apis/pipeline/v1beta1) e.g - [condition_types.go](./pkg/apis/pipeline/v1beta1/condition_types.go) This + [task_types.go](./pkg/apis/pipeline/v1beta1/task_types.go) This should implement the - [Defaultable](./pkg/apis/pipeline/v1beta1/condition_defaults.go) and - [Validatable](./pkg/apis/pipeline/v1beta1/condition_validation.go) + [Defaultable](./pkg/apis/pipeline/v1beta1/task_defaults.go) and + [Validatable](./pkg/apis/pipeline/v1beta1/task_validation.go) interfaces as they are needed for the webhook in the next step. 1. Register it with the [webhook](./cmd/webhook/main.go) 1. Add the new type to the