-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove last lingering unnecessarily exported functions #4296
Remove last lingering unnecessarily exported functions #4296
Conversation
/assign @imjasonh @vdemeester |
/retest |
fixes tektoncd#3262 There are a few things left, either by design or uncertainty: * `pkg/apis/pipeline/v1beta1/conversion_error.go`'s `ConvertErrorf` - I'm not entirely clear on whether this should be around or not. `CannotConvertError` is still used in tests in `pkg/apis/pipeline/v1alpha1`, and the whole thing is just messy enough that I'm not sure what to do. * `pkg/apis/pipeline/v1beta1/version_validation.go`'s `ValidateEnabledAPIFields` - it's referenced in `docs/developers/README.md` and I can't tell if that's something that could be intended to eb used in something depending on Tekton, not just in Tekton itself. * `pkg/pipelinerunmetrics/injection.go` and `pkg/taskrunmetrics/injection.go`'s `WithInformer` - these are both used as function references in their respective `.../fake/fake.go`s. Signed-off-by: Andrew Bayer <[email protected]>
58b7fef
to
40774e3
Compare
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm thanks @abayer
#4281 is removing all the references of the
|
Changes
fixes #3262
There are a few things left, either by design or uncertainty:
pkg/apis/pipeline/v1beta1/conversion_error.go
'sConvertErrorf
- I'm not entirely clear on whether this should be around or not.CannotConvertError
is still used in tests inpkg/apis/pipeline/v1alpha1
, and the whole thing is just messy enough that I'm not sure what to do.pkg/apis/pipeline/v1beta1/version_validation.go
'sValidateEnabledAPIFields
- it's referenced indocs/developers/README.md
and I can't tell if that's something that could be intended to eb used in something depending on Tekton, not just in Tekton itself.pkg/pipelinerunmetrics/injection.go
andpkg/taskrunmetrics/injection.go
'sWithInformer
- these are both used as function references in their respective.../fake/fake.go
s./kind cleanup
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes