Fix panic when pending pipelinerun is failed #4306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PipelineRuns that are created with status PipelineRunPending can be placed into a failed state before their execution begins. For example: a third-party controller may be watching for pending PipelineRuns to perform some checks on them prior to execution beginning. If those checks fail the controller might choose to set the PipelineRun status to failed with a relevant error message indicating which check failed and why. Prior to this commit when a pending PR failed our metrics code could panic because the PR's StartTime is nil. This commit adds a guard to the metrics code to ensure that StartTime is not nil before computing the PR's duration. If it is nil then we assume the duration is 0. A unit test confirming this behaviour has been added as well. (cherry picked from commit 0299c6c)
tekton-robot
added
release-note
tekton-robot
added
the
size/M
|
Cheers! /lgtm |
vdemeester
approved these changes
Oct 13, 2021
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
vdemeester
added
needs-cherry-pick
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Cheery picking PR: #4298 (All the credit goes to @sbwsg, thank you Scott 🙏 )
PipelineRuns that are created with status PipelineRunPending
can be placed into a failed state before their execution begins.
For example: a third-party controller may be watching for pending
PipelineRuns to perform some checks on them prior to execution
beginning. If those checks fail the controller might choose to
set the PipelineRun status to failed with a relevant error message
indicating which check failed and why.
Prior to this commit when a pending PR failed our metrics code
could panic because the PR's StartTime is nil.
This commit adds a guard to the metrics code to ensure that StartTime
is not nil before computing the PR's duration. If it is nil then
we assume the duration is 0. A unit test confirming this behaviour
has been added as well.
(cherry picked from commit 0299c6c)
Co-authored-by: sbwsg [email protected]
/kind bug
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes