Update docs to reflect resource requests of pods #4472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tekton previously modified step resource requests to request one large container (with the max resource request of any Step) and resource requests of 0 in all other containers. This behavior was modified in v0.28.0. Now, the Step resource requests are preserved (unless any LimitRanges are present). This commit updates the documentation to reflect this change. This commit also updates the description of how init container and container resource requests are combined to determine the resulting pod's resource requests, based on [Kubernetes documentation](https://kubernetes.io/docs/concepts/workloads/pods/init-containers/#resources).
tekton-robot
added
release-note-none
tekton-robot
added
the
size/M
|
/assign @vdemeester |
|
/test pull-tekton-pipeline-integration-tests |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
|
Nice, thank you! /lgtm |
|
/test pull-tekton-pipeline-integration-tests |
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Mar 17, 2022
roulettedares
added a commit
to roulettedares/jx3-pipeline-catalog
that referenced
this pull request
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tekton previously modified step resource requests to request one large container (with the max resource request of any Step)
and resource requests of 0 in all other containers. This behavior was modified in v0.28.0 (#4176). Now, the Step resource requests are preserved
(unless any LimitRanges are present). This commit updates the documentation to reflect this change.
This commit also updates the description of how init container and container resource requests are combined to determine the resulting pod's
resource requests, based on Kubernetes documentation.
/kind documentation
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
functionality, content, code)
Release Notes