Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TEP-0075: Implement object var replacement on task&taskrun level #4904

Merged
merged 1 commit into from
Jul 4, 2022
Merged

TEP-0075: Implement object var replacement on task&taskrun level #4904

merged 1 commit into from
Jul 4, 2022

Conversation

chuangw6
Copy link
Member

@chuangw6 chuangw6 commented May 24, 2022 •
edited by vdemeester
Loading

Changes

Implement variable replacement for object's individual attributes
on task&taskrun level.

[According to TEP-0075, when providing values for strings, Task and
Pipeline authors can access individual attributes of an object param;
they cannot access the object as whole.]

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Docs included if any changes are user facing
  • Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

- Added implementation for object variables replacement on task/taskrun level where only individual object keys can be referenced in the format of `$(params.<param_name>.<key_name>)`
- Users need to enabled alpha feature flag to have this pr's change applied.

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label May 24, 2022
@tekton-robot tekton-robot requested review from afrittoli and dlorenc May 24, 2022 05:54
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 24, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/apply.go 99.2% 97.7% -1.5

@chuangw6
Copy link
Member Author

/retest

@chuangw6
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

1 similar comment
@chuangw6
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. labels Jun 2, 2022
@ywluogg
Copy link
Contributor

ywluogg commented Jun 2, 2022

/assign @ywluogg

ywluogg
ywluogg reviewed Jun 8, 2022
View reviewed changes
Copy link
Contributor

@ywluogg ywluogg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM

pkg/reconciler/taskrun/resources/apply.go Outdated Show resolved Hide resolved
pkg/reconciler/taskrun/resources/apply.go Outdated Show resolved Hide resolved
pkg/reconciler/taskrun/resources/apply.go Show resolved Hide resolved
pkg/reconciler/taskrun/resources/apply_test.go Show resolved Hide resolved
@chuangw6 chuangw6 force-pushed the variable-replacement branch from bb88540 to 1d9bcd0 Compare June 15, 2022 18:54
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/apply.go 99.2% 97.7% -1.5

@chuangw6 chuangw6 force-pushed the variable-replacement branch from 1d9bcd0 to bd10c40 Compare June 15, 2022 18:58
@chuangw6
Copy link
Member Author

/assign @lbernick

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/apply.go 99.2% 97.7% -1.5

@chuangw6 chuangw6 force-pushed the variable-replacement branch from bd10c40 to 941925f Compare June 15, 2022 19:09
@tekton-robot tekton-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 15, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/apply.go 99.2% 99.2% 0.0

@tekton-robot tekton-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note Denotes a PR that will be considered when it comes time to generate release notes. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. labels Jun 15, 2022
@ywluogg
Copy link
Contributor

ywluogg commented Jun 15, 2022

/approve

@chuangw6
Copy link
Member Author

/test pull-tekton-pipeline-alpha-integration-tests

lbernick
lbernick approved these changes Jun 16, 2022
View reviewed changes
pkg/reconciler/taskrun/resources/apply_test.go Outdated Show resolved Hide resolved
pkg/reconciler/taskrun/resources/apply_test.go Outdated Show resolved Hide resolved
pkg/reconciler/taskrun/resources/apply_test.go Outdated Show resolved Hide resolved
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/apply.go 99.2% 99.2% 0.0

@chuangw6
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

1 similar comment
@chuangw6
Copy link
Member Author

/test pull-tekton-pipeline-integration-tests

@dibyom
Copy link
Member

dibyom commented Jun 17, 2022

Looks like the integration tests are timing out:

/test pull-tekton-pipeline-integration-tests

@ywluogg ywluogg mentioned this pull request Jun 22, 2022
Merged
@ywluogg
Copy link
Contributor

ywluogg commented Jul 4, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2022
@chuangw6 chuangw6 force-pushed the variable-replacement branch from a29e30e to 67f954b Compare July 4, 2022 18:53
@tekton-robot tekton-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels Jul 4, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick, ywluogg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chuangw6 chuangw6 force-pushed the variable-replacement branch from 67f954b to fb6e796 Compare July 4, 2022 18:54
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 4, 2022
@chuangw6
TEP-0075: Implement object var replacement on task&taskrun level
bf050f7 
Implement variable replacement for object's individual attributes
on task&taskrun level.

[According to TEP-0075, when providing values for strings, Task and
Pipeline authors can access individual attributes of an object param;
they cannot access the object as whole.]
@chuangw6 chuangw6 force-pushed the variable-replacement branch from fb6e796 to bf050f7 Compare July 4, 2022 19:04
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 4, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/apply.go 99.2% 99.2% 0.0

@chuangw6 chuangw6 closed this Jul 4, 2022
@chuangw6 chuangw6 reopened this Jul 4, 2022
@chuangw6
Copy link
Member Author

chuangw6 commented Jul 4, 2022

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 4, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/reconciler/taskrun/resources/apply.go 99.2% 99.2% 0.0

@chuangw6
Copy link
Member Author

chuangw6 commented Jul 4, 2022

/test pull-tekton-pipeline-integration-tests

@ywluogg
Copy link
Contributor

ywluogg commented Jul 4, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2022
@tekton-robot tekton-robot merged commit 380dbd0 into tektoncd:main Jul 4, 2022
@Yongxuanzhang Yongxuanzhang mentioned this pull request Sep 27, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ywluogg ywluogg ywluogg left review comments

@lbernick lbernick lbernick approved these changes

@afrittoli afrittoli Awaiting requested review from afrittoli

@dlorenc dlorenc Awaiting requested review from dlorenc

Assignees

@lbernick lbernick

@ywluogg ywluogg

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chuangw6 @tekton-robot @ywluogg @dibyom @lbernick