Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wlynch to entrypoint OWNERS #4999

Merged
merged 1 commit into from
Jun 17, 2022
Merged

Conversation

lbernick
Copy link
Member

Changes

wlynch is a Pipelines reviewer with significant familiarity/contributions to the entrypoint.
(Author of #4352, #4278, and #4238--the last is entrypoint docs.)

Our contributor ladder
states that reviewers "Can be allowed to /approve pull requests in specific sub-directories of a project
(by maintainer discretion)". However, this isn't frequently done in Pipelines in practice.
This change will allow us to experiment with more directory-based permissions as a potential pathway
for growing reviewers and approvers for Pipelines.

/kind misc

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • n/a Docs included if any changes are user facing
  • n/a Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Release notes block below has been filled in
    (if there are no user facing changes, use release note "NONE")

Release Notes

NONE

wlynch is a Pipelines reviewer with significant famililarity/contributions to the entrypoint.

Our [contributor ladder](https://github.com/tektoncd/community/blob/main/process.md#reviewer)
states that reviewers "Can be allowed to /approve pull requests in specific sub-directories of a project
(by maintainer discretion)". However, this isn't frequently done in Pipelines in practice.
This change will allow us to experiment with more directory-based permissions as a potential pathway
for growing reviewers and approvers for Pipelines.
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. kind/misc Categorizes issue or PR as a miscellaneuous one. labels Jun 17, 2022
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 17, 2022
@lbernick lbernick assigned lbernick, dibyom and jerop and unassigned lbernick Jun 17, 2022
@lbernick
Copy link
Member Author

FYI @wlynch

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dibyom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 17, 2022
@wlynch
Copy link
Member

wlynch commented Jun 17, 2022

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 17, 2022
@tekton-robot tekton-robot merged commit 7b9eb0c into tektoncd:main Jun 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/misc Categorizes issue or PR as a miscellaneuous one. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants