Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEP-0104] Populate Task-level Resource Requirements from PipelineRun to TaskRun #5212

Merged
merged 1 commit into from
Aug 3, 2022
Merged

[TEP-0104] Populate Task-level Resource Requirements from PipelineRun to TaskRun #5212

merged 1 commit into from
Aug 3, 2022

Conversation

austinzhao-go
Copy link
Contributor

@austinzhao-go austinzhao-go commented Jul 26, 2022 •
edited
Loading

Task-level resource requirements will be populated from PipelineRun to the created TaskRun

Changes

/kind feature

The related FR thread:
#4470
The related TEP:
TEP-0104: Task-level Resource Requirements

The previous PRs:
#4877 - Fields Addition & Validation w/ Docs Updates
#5054 - Add Validation for Step-level Resource Requirements
The follow-up PR:
#5082 - Update Pod with Task-level Resource Requirements

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs included if any changes are user facing
  • Has Tests included if any functionality added or changed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including
    functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings)
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Jul 26, 2022
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 26, 2022
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 85.7% 85.9% 0.2

@austinzhao-go austinzhao-go changed the title [TEP-0104] Populate Task-level Resource Config [TEP-0104] Populate Task-level Resource Requirements from Jul 26, 2022
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lbernick

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2022
@austinzhao-go austinzhao-go changed the title [TEP-0104] Populate Task-level Resource Requirements from [TEP-0104] Populate Task-level Resource Requirements from PipelineRun to TaskRun Jul 26, 2022
@tekton-robot tekton-robot added release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 26, 2022
@austinzhao-go austinzhao-go force-pushed the tep-0104/pipelinerun-task-level-config branch from adbb9c8 to 7adfb71 Compare July 26, 2022 14:25
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 85.7% 85.9% 0.2

This was referenced Jul 26, 2022
Closed
Merged
@abayer
Copy link
Contributor

abayer commented Jul 26, 2022

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@abayer: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-tekton-pipeline-alpha-integration-tests
  • /test pull-tekton-pipeline-build-tests
  • /test pull-tekton-pipeline-integration-tests
  • /test tekton-pipeline-unit-tests

The following commands are available to trigger optional jobs:

  • /test pull-tekton-pipeline-go-coverage

Use /test all to run all jobs.

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@austinzhao-go
Copy link
Contributor Author

/kind feature

@tekton-robot tekton-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jul 26, 2022
@austinzhao-go
Copy link
Contributor Author

/retest

@austinzhao-go
Copy link
Contributor Author

/test all

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 85.7% 85.9% 0.2

@austinzhao-go austinzhao-go force-pushed the tep-0104/pipelinerun-task-level-config branch from 7adfb71 to 5237250 Compare July 26, 2022 19:45
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 85.7% 85.9% 0.2

dibyom
dibyom reviewed Jul 26, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @austinzhao-go Couple of really minor nits, otherwise LGTM!

pkg/apis/pipeline/v1beta1/pipelinerun_types.go Show resolved Hide resolved
pkg/reconciler/pipelinerun/pipelinerun_test.go Outdated Show resolved Hide resolved
pkg/reconciler/pipelinerun/pipelinerun_test.go Outdated Show resolved Hide resolved
@austinzhao-go
[TEP-0104] Populate Task-level Resource Requirements from Pipeline-
99bb035 
Run to TaskRun

Task-level resource requirements will be populated from PipelineRun
to the created TaskRun and applied on the related Pod.
@austinzhao-go austinzhao-go force-pushed the tep-0104/pipelinerun-task-level-config branch from 5237250 to 99bb035 Compare July 27, 2022 15:24
@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1beta1/pipelinerun_types.go 85.7% 85.9% 0.2

@austinzhao-go austinzhao-go mentioned this pull request Aug 3, 2022
Closed
7 tasks
dibyom
dibyom reviewed Aug 3, 2022
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2022
@austinzhao-go
Copy link
Contributor Author

/retest

@tekton-robot tekton-robot merged commit 73a8906 into tektoncd:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom left review comments

@lbernick lbernick lbernick approved these changes

@imjasonh imjasonh Awaiting requested review from imjasonh

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@austinzhao-go @tekton-robot @abayer @dibyom @lbernick