Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing build steps from initContainers to Containers #564

Merged
merged 6 commits into from
Mar 5, 2019
Merged

Changing build steps from initContainers to Containers #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
535f5cd
Changing build steps from initContainers to Containers
nader-ziada Feb 26, 2019
8ebcf1c
add support for getting remote image
nader-ziada Feb 28, 2019
e6274a8
YAML test that ensures that a build with 2 steps has those steps exec…
nader-ziada Feb 28, 2019
57cd24d
update the entrypoint copy step to be more generic
nader-ziada Mar 1, 2019
9b72a85
update yaml examples (tests) to use command
nader-ziada Mar 1, 2019
8a506cc
address comments on PR #564
nader-ziada Mar 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
1 change: 1 addition & 0 deletions .ko.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,5 @@ baseImageOverrides:
github.com/knative/build-pipeline/cmd/creds-init: gcr.io/knative-nightly/github.com/knative/build/build-base:latest
github.com/knative/build-pipeline/cmd/git-init: gcr.io/knative-nightly/github.com/knative/build/build-base:latest
github.com/knative/build-pipeline/cmd/bash: busybox # image should have shell in $PATH
github.com/knative/build-pipeline/cmd/entrypoint: busybox # image should have shell in $PATH
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does this image need a shell for?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thinking about it now again I guess it doesn't really need a shell. Will try it again without this

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to have a shell because we are using this same image for the step to copy the binary to the tools/entrypoint location

github.com/knative/build-pipeline/cmd/gsutil: google/cloud-sdk:alpine # image should have gsutil in $PATH
237 changes: 226 additions & 11 deletions Gopkg.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading