Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: PullRequestResource #779

Closed
wants to merge 1 commit into from
Closed

WIP: PullRequestResource #779

wants to merge 1 commit into from

Conversation

dlorenc
Copy link
Contributor

@dlorenc dlorenc commented Apr 22, 2019

This is not ready for review! It is meant to accompany #778 as a draft/POC and this design doc.

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 22, 2019
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label Apr 22, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dlorenc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Apr 22, 2019
@tekton-robot
Copy link
Collaborator

@dlorenc: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-tekton-pipeline-build-tests ad34be7 link /test pull-tekton-pipeline-build-tests

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@bobcatfish
Copy link
Collaborator

v exciting @dlorenc ! could you include in this somewhere (e.g. PR description and/or comments in pullrequest-init/main.go) a brief description of what the interface is here? e.g. what files will be provided via the download, and what functionality is available for upload?

@abayer
Copy link
Contributor

abayer commented Apr 22, 2019

cc @rawlingsj @ccojocar @pmuir - would be interested to hear your thoughts from a JX perspective.

@@ -0,0 +1,244 @@
/*
Copyright 2018 The Knative Authors
Copy link
Member

@hrishin hrishin May 2, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wondering 🤔, do we still want to continue with Knative copyrights?
(my bad if I commented early, can understand its WIP PR)

@vdemeester
Copy link
Member

Closing this one in favor of #895

@vdemeester vdemeester closed this May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants