-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: PullRequestResource #779
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dlorenc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@dlorenc: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
v exciting @dlorenc ! could you include in this somewhere (e.g. PR description and/or comments in |
cc @rawlingsj @ccojocar @pmuir - would be interested to hear your thoughts from a JX perspective. |
@@ -0,0 +1,244 @@ | |||
/* | |||
Copyright 2018 The Knative Authors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering 🤔, do we still want to continue with Knative
copyrights?
(my bad if I commented early, can understand its WIP PR)
Closing this one in favor of #895 |
This is not ready for review! It is meant to accompany #778 as a draft/POC and this design doc.