Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify the section about installing in custom namespace #881

Merged
merged 1 commit into from
May 21, 2019
Merged

Modify the section about installing in custom namespace #881

merged 1 commit into from
May 21, 2019

Conversation

houshengbo
Copy link

@houshengbo houshengbo commented May 20, 2019 •
edited
Loading

We need to replace the default namespace with the desired namespace
in order to work.

Fixes: #882

Changes

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide
for more details.

Release Notes

release-note

Modify the section about installing in custom namespace
9068cd0 
We need to replace the default namespace with the desired namespace
in order to work.
@tekton-robot tekton-robot requested a review from dlorenc May 20, 2019 15:11
@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label May 20, 2019
@tekton-robot tekton-robot requested a review from vdemeester May 20, 2019 15:11
@tekton-robot tekton-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 20, 2019
@houshengbo
Copy link
Author

/assign @vdemeester

@dibyom
Copy link
Member

dibyom commented May 20, 2019

/ok-to-test

@tekton-robot tekton-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 20, 2019
dibyom
dibyom approved these changes May 20, 2019
View reviewed changes
Copy link
Member

@dibyom dibyom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 20, 2019
@bobcatfish
Copy link
Collaborator

Thanks for this @houshengbo ! ❤️

/approve

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bobcatfish, dibyom, houshengbo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2019
@tekton-robot tekton-robot merged commit c191e97 into tektoncd:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dibyom dibyom dibyom approved these changes

@dlorenc dlorenc Awaiting requested review from dlorenc

@vdemeester vdemeester Awaiting requested review from vdemeester

Assignees

@vdemeester vdemeester

@dibyom dibyom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The instruction about installing in custom namespace does not work
6 participants
@houshengbo @dibyom @bobcatfish @tekton-robot @vdemeester @googlebot