Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct setting for kaniko in tasks #883

Merged
merged 1 commit into from
May 21, 2019
Merged

Correct setting for kaniko in tasks #883

merged 1 commit into from
May 21, 2019

Conversation

vincent-pli
Copy link
Member

@vincent-pli vincent-pli commented May 21, 2019 •
edited
Loading

Changes

The Kaniko setting in docs and example is not correct, will hit permission error.
Details please check this issue: #706
Many around me hit this issue.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

release-note

@googlebot googlebot added the cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit label May 21, 2019
@tekton-robot tekton-robot requested review from dlorenc and imjasonh May 21, 2019 00:48
@tekton-robot tekton-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2019
@imjasonh
Copy link
Member

/ok-to-test
/lgtm
/approve

Thanks!

@tekton-robot tekton-robot added lgtm Indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 21, 2019
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ImJasonH, vincent-pli

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2019
@tekton-robot tekton-robot merged commit 62b7937 into tektoncd:master May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlorenc dlorenc Awaiting requested review from dlorenc

@imjasonh imjasonh Awaiting requested review from imjasonh

Assignees

@imjasonh imjasonh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Trying to make the CLA bot happy with ppl from different companies work on one commit lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vincent-pli @imjasonh @tekton-robot @googlebot