Always make sure module cache is downloaded. #174
Conversation
This ensures that `go mod download` in tests/scripts to make sure all dependencies are present. This should generally only be slow on the first attempt when it needs to download the modules locally, but subsequent calls should result in no change. This solves an issue raised in tektoncd/pipeline#1792 where the license DB used by a required tool wasn't being downloaded.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cc @vdemeester |
tekton-robot
added
the
size/XS
There was a problem hiding this comment.
We should probably either put this in a function (to be explicitely called, in the main or wherever), or at least have a message about it (using header or …). Otherwise, it can be really really weird to wait a long time initially, not knowing why.
Also, we should check if go.mod is present, shouldn't we ?
|
ping @wlynch - still worth doing this or should we close for now? |
|
Following up here, @wlynch wdyt about closing this for now and revisiting at a later time? |
|
Agreeing with @bobcatfish and @sbwsg, let's close this for now 😉 |
|
@vdemeester: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Changes
This ensures that
go mod downloadin tests/scripts to make sure alldependencies are present. This should generally only be slow on the first
attempt when it needs to download the modules locally, but subsequent calls
should result in no change.
This solves an issue raised in
tektoncd/pipeline#1792 where the license DB used
by a required tool wasn't being downloaded.
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.