Add decorate flag on pull-tekton-experimental-helm-lint

[eddycharly]

Added decorate: true on pull-tekton-experimental-helm-lint prow job.

[tekton-robot]

Hi @eddycharly. Thanks for your PR.

I'm waiting for a tektoncd member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vdemeester]

/ok-to-test
/cc @afrittoli

[afrittoli]

/approve

[vdemeester]

/lgtm

[tekton-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: afrittoli, vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [afrittoli,vdemeester]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bobcatfish]

It's too late to do this in the commit message, but @eddycharly (or @vdemeester if you know) could you explain a bit more about why this flag is needed? i.e. what this adds, and was something broken without it?

Thanks!

[eddycharly]

@bobcatfish it adds decoration to the pod running the job.
That is, it adds some other containers that are responsible of cloning the repository, setting the correct working dir, uploading logs and artifacts etc...

[bobcatfish]

Thanks @eddycharly that helps! I just noticed #305 as well - i mentioned there but having an issue or something that these PRs could link to would help provide some context

I know it's hard to get these prow things working first shot since it's hard to try them out :(

[eddycharly]

You can read more here: https://github.com/kubernetes/test-infra/blob/master/prow/pod-utilities.md

I wrote the job for pipeline agent first but i reverted to kubernetes agent while thinking the pipeline agent was the issue.
In the end the issue was not directly related to the agent, i could try to use pipeline agent again but i fear logs would not be uploaded.

[bobcatfish]

Thanks @eddycharly that helps too!

What I mean though is the context for adding pull-tekton-experimental-helm-lint which I assume you are working toward adding with these PRs? (Basically I have to guess the context for this work at the moment, maybe I'm wrong)

[eddycharly]

Working towards #306.

@bobcatfish i created the issue, linking it in the PRs for history.