Add build of dogfooding images in multi-arch form #629
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tekton-robot
added
the
size/L
barthy1
force-pushed
the
dogfooding_ma_images
branch
from
31636f8 to
2e94acd
Compare
|
cc @afrittoli |
16 tasks
tekton-robot
added
the
approved
afrittoli
reviewed
Nov 10, 2020
tekton/resources/images/overlays/multi-arch/image-build-trigger-template.yaml
Outdated
Show resolved
Hide resolved
tekton/resources/images/overlays/multi-arch/image-build-trigger-template.yaml
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,9 @@ | |||
| nameReference: | |||
| - kind: TriggerBinding | |||
There was a problem hiding this comment.
NIT: There's no need to use kustomize on bindings, you can specify multiple bindings in a trigger, so for me the way to go would be to have the common base binding and another platform binding which is only used on the multi-arch trigger.
barthy1
force-pushed
the
dogfooding_ma_images
branch
3 times, most recently
from
8007a07 to
cf14dc6
Compare
afrittoli
reviewed
Nov 11, 2020
Extend current cronjobs/triggers setup to build dogfooding images in multi-arch form when it's necessary: - use separate TriggerTemplates and TriggerBindings for single-arch and multi-arch cases - extend eventlistener to filter requests for single-arch and multi-arch builds - add PLATFORMS parameter to cronjobs to be able to specify for which platforms multi-arch image should be - extend several image cronjobs to use multi-arch build (`tkn`, `alpine-git-nonroot`, `skopeo`) Signed-off-by: Yulia Gaponenko <[email protected]>
barthy1
force-pushed
the
dogfooding_ma_images
branch
from
cf14dc6 to
0657180
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: afrittoli, vdemeester The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Extend current cronjobs/triggers setup to build dogfooding images in multi-arch form when it's necessary:
tkn,alpine-git-nonroot,skopeo)buildxin main container anddindsidecar are usedNot every image can be built with this approach, so I suggest to use it only for images, which are required for the tests.
The build cronjobs were updated to those exact images.
/kind misc
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.