Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a working validate example #117

Closed
ncskier opened this issue Sep 13, 2019 · 4 comments · Fixed by #131
Closed

Create a working validate example #117

ncskier opened this issue Sep 13, 2019 · 4 comments · Fixed by #131
Assignees

Comments

@ncskier
Copy link
Member

ncskier commented Sep 13, 2019

Expected Behavior

Now that #89 has been merged, Triggers has the capability to validate http POST events. For someone learning about Triggers, I expect there to be example YAML files that I can apply to create a working example of this validation.

Actual Behavior

There is nothing in the examples/ directory that creates an EventListener with working validation.

Additional Info

It could be very helpful to have an accompanying README, like the one created in #113.

@khrm
Copy link
Contributor

khrm commented Sep 13, 2019

/assign khrm

@ncskier
Copy link
Member Author

ncskier commented Sep 13, 2019

Thanks for picking this up @khrm! 🙂

@ncskier
Copy link
Member Author

ncskier commented Sep 13, 2019

@vtereso pointed out that the validate-event.md page has a static example, so under the issue, please update the page to use your new validation example with <!-- FILE: examples/path/to/new/validate-example.yaml --> and run ./hack/update-docs.sh

@akihikokuroda
Copy link
Member

The validate-github-event.yaml has issue #119

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants