Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reducing the pods related to EventListener #370

Closed
khrm opened this issue Jan 22, 2020 · 7 comments
Closed

Reducing the pods related to EventListener #370

khrm opened this issue Jan 22, 2020 · 7 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. maybe-next-milestone

Comments

@khrm
Copy link
Contributor

khrm commented Jan 22, 2020

Expected Behavior

There should be fewer pods or deployments related to EventListener.

Actual Behavior

At present, you can any number of pods handling EventListener logic. This led to wastage of resources due to the proliferations of these pods.

Additional Info

Current Proposal:
https://docs.google.com/document/d/1is5sJMkqWMnOa4fP87H39auTnWR1IKFu7TxTkMNJV5c/edit#

@vdemeester
Copy link
Member

/kind feature

@khrm
Copy link
Contributor Author

khrm commented Apr 28, 2020

Summary of Discussion on this &
#456

  1. Design recommended in both scenarios are based on having URL to determine EL or TriggerCRD .
  2. Main issue with these designs are RBAC. Should be give RBAC permissions similar to controller for a global EventListener?
  3. If we don't want to 2, then we would need to give permission to create Pod with a particular SA in every namespace to EL deployment which relates to Triggers. Now this creates another security issue that a lot of transient pods could be created by just hitting the URL.

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 14, 2020
@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dibyom
Copy link
Member

dibyom commented Aug 14, 2020

Similar to #456 -> part of TEP-009 and TEP-008. I think we can keep this closed and open other issues for those two.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. maybe-next-milestone
Projects
None yet
Development

No branches or pull requests

5 participants