Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Configurable Services/Deployments for EventListener Sinks #440

Closed
dibyom opened this issue Feb 13, 2020 · 3 comments
Closed

FR: Configurable Services/Deployments for EventListener Sinks #440

dibyom opened this issue Feb 13, 2020 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/duplicate Indicates an issue is a duplicate of other open issue.

Comments

@dibyom
Copy link
Member

dibyom commented Feb 13, 2020

Expected Behavior

A user should have more control over their EventListener sink. Today the only option we provide is the serviceType. Users might want to control the number of replicas for their deployments, loadBalancerIPs etc.

Actual Behavior

We don't provide a declarative way for users to configure any of these. Users may modify the created sink objects directly but we do not provide any guarantees that the EL reconciler will not overwrite the user changes

Additional Info

  1. Some related discussion in Reducing the pods related to EventListener #370
  2. An alternative to explore - instead of adding more configuration for the users, add different modes of deployments e.g. deploy the EL sink as a knative service instead
@dibyom dibyom added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 13, 2020
@akihikokuroda
Copy link
Member

The requirement for the service is already covered but here is information for EKS configuration: https://github.com/tektoncd/experimental/blob/master/webhooks-extension/docs/GettingStarted.md#notes-for-amazon-eks

@dibyom
Copy link
Member Author

dibyom commented Mar 30, 2020

Closing in favor of #505
/triage duplicate
/close

@tekton-robot tekton-robot added the triage/duplicate Indicates an issue is a duplicate of other open issue. label Mar 30, 2020
@tekton-robot
Copy link

@dibyom: Closing this issue.

In response to this:

Closing in favor of #505
/triage duplicate
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Development

No branches or pull requests

3 participants