Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Knative Dependencies to Align with Pipelines #627

Closed
danielhelfand opened this issue Jun 22, 2020 · 1 comment · Fixed by #661
Closed

Update Knative Dependencies to Align with Pipelines #627

danielhelfand opened this issue Jun 22, 2020 · 1 comment · Fixed by #661
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@danielhelfand
Copy link
Member

Expected Behavior

To be able to deploy triggers without issues.

Actual Behavior

On some distributions of Kubernetes, the following error can occur due to the version of Knative dependencies used by triggers:

tekton-triggers-controller {"level":"fatal","logger":"controller","caller":"sharedmain/main.go:149","msg":"Version check failed","error │
│ ":"kubernetes version \"\" is not compatible, need at least \"v1.15.0\" (this can be overridden with the env var \"KUBERNETES_MIN_VERSI │
│ ON\")","stacktrace":"knative.dev/pkg/injection/sharedmain.MainWithConfig\n\tknative.dev/[email protected]/injectio │
│ n/sharedmain/main.go:149\nknative.dev/pkg/injection/sharedmain.MainWithContext\n\tknative.dev/[email protected]/in │
│ jection/sharedmain/main.go:114\nknative.dev/pkg/injection/sharedmain.Main\n\tknative.dev/[email protected]/injecti │
│ on/sharedmain/main.go:98\nmain.main\n\tgithub.com/tektoncd/triggers@/cmd/controller/main.go:32\nruntime.main\n\truntime/proc.go:203"}

The workaround is to set the KUBERNETES_MIN_VERSION environment variable on the deployments for the triggers controller/webhook to be the version of the cluster being used. This was also previously a problem for pipelines as well before tektoncd/pipeline#2721.

The error comes from how the server version is validated here, which has been updated in pipelines.

Is there any reason for building around the Knative dependencies currently used?

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Jun 22, 2020
@dibyom
Copy link
Member

dibyom commented Jun 26, 2020

Is there any reason for building around the Knative dependencies currently used?

Not that I'm aware of. We just need to bump our dependencies!

dibyom added a commit to dibyom/triggers that referenced this issue Jul 6, 2020
Needed for tektoncd#637 and fixes tektoncd#627

Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom added a commit to dibyom/triggers that referenced this issue Jul 6, 2020
Needed for tektoncd#635 and fixes tektoncd#627

Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom added a commit to dibyom/triggers that referenced this issue Jul 6, 2020
Needed for tektoncd#635 and fixes tektoncd#627

Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom added a commit to dibyom/triggers that referenced this issue Jul 7, 2020
The update to knative is to pick up genreconciler and in turn requires us to update our pipelines dependency to v0.13.2. I had to update the hack/ scripts and remove some old pinned dependencies, and drop some deprecated functions and flags.

Needed for tektoncd#635 and fixes tektoncd#627

Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom added a commit to dibyom/triggers that referenced this issue Jul 7, 2020
The update to knative is to pick up genreconciler and in turn requires us to update our pipelines dependency to v0.13.2. I had to update the hack/ scripts and remove some old pinned dependencies, and drop some deprecated functions and flags.

Needed for tektoncd#635 and fixes tektoncd#627

Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom added a commit to dibyom/triggers that referenced this issue Jul 7, 2020
The update to knative is to pick up genreconciler and in turn requires us to update our pipelines dependency to v0.13.2. I had to update the hack/ scripts and remove some old pinned dependencies, and drop some deprecated functions and flags.

Needed for tektoncd#635 and fixes tektoncd#627

Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom added a commit to dibyom/triggers that referenced this issue Jul 7, 2020
The update to knative is to pick up genreconciler and in turn requires us to
update our pipelines dependency to v0.13.2. I had to update the hack/ scripts,
remove some old pinned dependencies, and drop some deprecated functions and
flags. To get the webhook cert generation to work again, I had to replace
`sharedmain.MainWithContext` with `sharedmain.WebhookMainWihtConfig`.

Needed for tektoncd#635 and fixes tektoncd#627

Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom added a commit to dibyom/triggers that referenced this issue Jul 7, 2020
The update to knative is to pick up genreconciler and in turn requires us to
update our pipelines dependency to v0.13.2. I had to update the hack/ scripts,
remove some old pinned dependencies, and drop some deprecated functions and
flags. To get the webhook cert generation to work again, I had to replace
`sharedmain.MainWithContext` with `sharedmain.WebhookMainWihtConfig`.

Needed for tektoncd#635 and fixes tektoncd#627

Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom added a commit to dibyom/triggers that referenced this issue Jul 8, 2020
The update to knative is to pick up genreconciler and in turn requires us to
update our pipelines dependency to v0.13.2. I had to update the hack/ scripts,
remove some old pinned dependencies, and drop some deprecated functions and
flags. To get the webhook cert generation to work again, I had to replace
`sharedmain.MainWithContext` with `sharedmain.WebhookMainWihtConfig`.

Needed for tektoncd#635 and fixes tektoncd#627

Signed-off-by: Dibyo Mukherjee <[email protected]>
tekton-robot pushed a commit that referenced this issue Jul 8, 2020
The update to knative is to pick up genreconciler and in turn requires us to
update our pipelines dependency to v0.13.2. I had to update the hack/ scripts,
remove some old pinned dependencies, and drop some deprecated functions and
flags. To get the webhook cert generation to work again, I had to replace
`sharedmain.MainWithContext` with `sharedmain.WebhookMainWihtConfig`.

Needed for #635 and fixes #627

Signed-off-by: Dibyo Mukherjee <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants