-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Knative Dependencies to Align with Pipelines #627
Labels
kind/bug
Categorizes issue or PR as related to a bug.
Comments
Closed
Not that I'm aware of. We just need to bump our dependencies! |
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jul 6, 2020
Needed for tektoncd#637 and fixes tektoncd#627 Signed-off-by: Dibyo Mukherjee <[email protected]>
3 tasks
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jul 6, 2020
Needed for tektoncd#635 and fixes tektoncd#627 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jul 6, 2020
Needed for tektoncd#635 and fixes tektoncd#627 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jul 7, 2020
The update to knative is to pick up genreconciler and in turn requires us to update our pipelines dependency to v0.13.2. I had to update the hack/ scripts and remove some old pinned dependencies, and drop some deprecated functions and flags. Needed for tektoncd#635 and fixes tektoncd#627 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jul 7, 2020
The update to knative is to pick up genreconciler and in turn requires us to update our pipelines dependency to v0.13.2. I had to update the hack/ scripts and remove some old pinned dependencies, and drop some deprecated functions and flags. Needed for tektoncd#635 and fixes tektoncd#627 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jul 7, 2020
The update to knative is to pick up genreconciler and in turn requires us to update our pipelines dependency to v0.13.2. I had to update the hack/ scripts and remove some old pinned dependencies, and drop some deprecated functions and flags. Needed for tektoncd#635 and fixes tektoncd#627 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jul 7, 2020
The update to knative is to pick up genreconciler and in turn requires us to update our pipelines dependency to v0.13.2. I had to update the hack/ scripts, remove some old pinned dependencies, and drop some deprecated functions and flags. To get the webhook cert generation to work again, I had to replace `sharedmain.MainWithContext` with `sharedmain.WebhookMainWihtConfig`. Needed for tektoncd#635 and fixes tektoncd#627 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jul 7, 2020
The update to knative is to pick up genreconciler and in turn requires us to update our pipelines dependency to v0.13.2. I had to update the hack/ scripts, remove some old pinned dependencies, and drop some deprecated functions and flags. To get the webhook cert generation to work again, I had to replace `sharedmain.MainWithContext` with `sharedmain.WebhookMainWihtConfig`. Needed for tektoncd#635 and fixes tektoncd#627 Signed-off-by: Dibyo Mukherjee <[email protected]>
dibyom
added a commit
to dibyom/triggers
that referenced
this issue
Jul 8, 2020
The update to knative is to pick up genreconciler and in turn requires us to update our pipelines dependency to v0.13.2. I had to update the hack/ scripts, remove some old pinned dependencies, and drop some deprecated functions and flags. To get the webhook cert generation to work again, I had to replace `sharedmain.MainWithContext` with `sharedmain.WebhookMainWihtConfig`. Needed for tektoncd#635 and fixes tektoncd#627 Signed-off-by: Dibyo Mukherjee <[email protected]>
tekton-robot
pushed a commit
that referenced
this issue
Jul 8, 2020
The update to knative is to pick up genreconciler and in turn requires us to update our pipelines dependency to v0.13.2. I had to update the hack/ scripts, remove some old pinned dependencies, and drop some deprecated functions and flags. To get the webhook cert generation to work again, I had to replace `sharedmain.MainWithContext` with `sharedmain.WebhookMainWihtConfig`. Needed for #635 and fixes #627 Signed-off-by: Dibyo Mukherjee <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Expected Behavior
To be able to deploy triggers without issues.
Actual Behavior
On some distributions of Kubernetes, the following error can occur due to the version of Knative dependencies used by triggers:
The workaround is to set the
KUBERNETES_MIN_VERSION
environment variable on the deployments for the triggers controller/webhook to be the version of the cluster being used. This was also previously a problem for pipelines as well before tektoncd/pipeline#2721.The error comes from how the server version is validated here, which has been updated in pipelines.
Is there any reason for building around the Knative dependencies currently used?
/kind bug
The text was updated successfully, but these errors were encountered: