-
Notifications
You must be signed in to change notification settings - Fork 420
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump Knative, Tekton and K8s imports #1209
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The following is the coverage report on the affected files.
|
The pipeline PR this is pulling in: tektoncd/pipeline#4198 This should subsume: #1196 as well, I'll coordinate with @piyush-garg to make sure I didn't miss anything. |
d5e5e02
to
f4d907e
Compare
The following is the coverage report on the affected files.
|
/test pull-tekton-triggers-integration-tests Not sure why this example would be affected, so let's see if it is a flake. |
ok, so something about the |
f4d907e
to
d3e2467
Compare
The following is the coverage report on the affected files.
|
Not sure if I've got things set up properly, but when I run this locally I am seeing:
|
d3e2467
to
bd744c6
Compare
Ok, after a bunch of debugging I finally figured out that it was that the webhook was AWOL because of some logic in the knative/pkg bump that expanded the permissions needed to include Here's the same change in pipelines when I bumped things there: tektoncd/pipeline@9d74f3f#diff-d5a724e46fb38be29b6dc700b6799f79f9d9178c6729ef5172d477f022918bb2R103 |
The following is the coverage report on the affected files.
|
To expand a bit... The test was failing because it relies on the defaulting webhook to convert the v1alpha1 resource into the right shape for the dispatch logic. In particular because this used |
bd744c6
to
be7fb29
Compare
The Pipelines PR landed, so I updated this and removed the WIP. |
The following is the coverage report on the affected files.
|
be7fb29
to
785be91
Compare
The following is the coverage report on the affected files.
|
Going to close this and fold what it does into #1207 since the main motivation for keeping it separate was to make reviewing the patches @piyush-garg incorporated clearer. |
/kind cleanup
This is WIP until the change to pipeline lands, at which point I'll update here. I'm staging this to let CI do the heavy lifting for me.
cc @piyush-garg
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Release Notes