Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Edit this page' and 'Create an issue' links on the website #580

Merged
merged 1 commit into from
May 18, 2020

Conversation

AlanGreene
Copy link
Member

Changes

tektoncd/website#65

Add a cascading page property to the frontmatter of docs/README.md
that will apply to all child pages displayed in the Triggers section
of the docs on the website.

This ensures the 'Edit this page' and 'Create an issue' links in
the sidebar point to the Triggers repo instead of the website repo.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Add a cascading page property to the frontmatter of docs/README.md
that will apply to all child pages displayed in the Triggers section
of the docs on the website.

This ensures the 'Edit this page' and 'Create an issue' links in
the sidebar point to the Triggers repo instead of the website repo.
@tekton-robot tekton-robot requested review from dlorenc and iancoffey May 18, 2020 15:54
@tekton-robot tekton-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 18, 2020
@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncskier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 18, 2020
@ncskier
Copy link
Member

ncskier commented May 18, 2020

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label May 18, 2020
@tekton-robot tekton-robot merged commit b8ca4f0 into tektoncd:master May 18, 2020
@AlanGreene AlanGreene deleted the docs_edit_link branch May 18, 2020 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants