Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Edit this page" leads to 404 for sub pages #65

Closed
AlanGreene opened this issue Mar 31, 2020 · 20 comments
Closed

"Edit this page" leads to 404 for sub pages #65

AlanGreene opened this issue Mar 31, 2020 · 20 comments
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.

Comments

@AlanGreene
Copy link
Member

Expected Behavior

Clicking the 'Edit this page' link should bring me to the corresponding file in GitHub.

Actual Behavior

Sub-pages under 'Tasks and Pipelines' and 'Triggers' lead to a 404

Steps to Reproduce the Problem

  1. Go to https://tekton.netlify.com/docs/pipelines/pipelineruns/
  2. Click 'Edit this page' in the top right corner
  3. Land on https://github.com/tektoncd/website//edit/master/content/en/docs/Pipelines/pipelineruns.md which gives a 404

Additional Info

Sub-pages for Pipelines and Triggers are being synced from the docs folder in their respective repos, so the 'Edit this page' links pointing to the website repo are wrong.

@AlanGreene
Copy link
Member Author

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 2, 2020
@tualeron
Copy link
Contributor

/kind documentation

@tekton-robot tekton-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 15, 2020
@tualeron
Copy link
Contributor

/help-wanted

@popcor255
Copy link
Member

/assign @popcor255

popcor255 added a commit to popcor255/tekton-website that referenced this issue May 6, 2020
This commit is a fix for [issue 65](tektoncd#65). The right side-navbar had a link to github to edit the page. However, the reference was to the webiste. The website does not hold any documentation. This is confusing for the user. Since, editing the index will be ignored and some docs are missing on the website repo because the source of truth is the project repo. Removing the link is a temporary solution to fix broken links. The link was removed because it confuses the user.
@AlanGreene
Copy link
Member Author

PRs open against dashboard + each of the repos currently syncing docs to the website. Ideally in future we wouldn't need to make this kind of change in each repo, but the alternative would require changes to the script to detect and modify the frontmatter block inside a HTML comment in a markdown file... This seems like it would be more likely to cause problems so I went with the simpler approach for now.

@AlanGreene
Copy link
Member Author

/close

@tekton-robot
Copy link

@AlanGreene: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member Author

Looks like this is back... #186 (comment)

/reopen

@tekton-robot tekton-robot reopened this Oct 28, 2020
@tekton-robot
Copy link

@AlanGreene: Reopened this issue.

In response to this:

Looks like this is back... #186 (comment)

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@popcor255
Copy link
Member

#187 There is a fix @AlanGreene

@AlanGreene
Copy link
Member Author

@popcor255 #187 does fix a number of cases of broken links, but as far as I can tell the 'Edit this page' links are a totally different issue. I fixed this originally back in May by adding some config to the frontmatter of the root docs page for each project (see the PRs above) that should be read to determine the project base URL when constructing that link specifically. I'll see if I can figure out why it's broken again...

@tekton-robot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale with a justification.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle stale

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 26, 2021
@tekton-robot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
Rotten issues close after an additional 30d of inactivity.
If this issue is safe to close now please do so with /close with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/lifecycle rotten

Send feedback to tektoncd/plumbing.

@tekton-robot tekton-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Feb 25, 2021
@tekton-robot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

@tekton-robot
Copy link

@tekton-robot: Closing this issue.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen with a justification.
Mark the issue as fresh with /remove-lifecycle rotten with a justification.
If this issue should be exempted, mark the issue as frozen with /lifecycle frozen with a justification.

/close

Send feedback to tektoncd/plumbing.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member Author

This is still an issue, the edit links are broken and we should fix them.
/reopen

@tekton-robot tekton-robot reopened this May 24, 2021
@tekton-robot
Copy link

@AlanGreene: Reopened this issue.

In response to this:

This is still an issue, the edit links are broken and we should fix them.
/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@AlanGreene
Copy link
Member Author

/lifecycle frozen

@tekton-robot tekton-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels May 24, 2021
@afrittoli afrittoli added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Nov 3, 2021
@afrittoli afrittoli changed the title Edit this page leads to 404 for sub pages "Edit this page" leads to 404 for sub pages Nov 3, 2021
@afrittoli
Copy link
Member

Looking at the latest docsy docs I think this could be solved by:

---
title: Some super section
path_base_for_github_subdir:
  from: content/some-section/(.*?)/_index.md
  to: $1/README.md
cascade:
  github_repo: https://github.com/some-username/another-repo/
  github_subdir: docs
  path_base_for_github_subdir: content/some-section
...
---

@geriom geriom mentioned this issue Jan 25, 2022
2 tasks
@AlanGreene
Copy link
Member Author

This is currently working, the edit links point to the correct location in the repo for the owning project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. kind/documentation Categorizes issue or PR as related to documentation. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness.
Projects
None yet
Development

No branches or pull requests

5 participants