-
Notifications
You must be signed in to change notification settings - Fork 155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Edit this page" leads to 404 for sub pages #65
Comments
/kind bug |
/kind documentation |
/help-wanted |
/assign @popcor255 |
This commit is a fix for [issue 65](tektoncd#65). The right side-navbar had a link to github to edit the page. However, the reference was to the webiste. The website does not hold any documentation. This is confusing for the user. Since, editing the index will be ignored and some docs are missing on the website repo because the source of truth is the project repo. Removing the link is a temporary solution to fix broken links. The link was removed because it confuses the user.
PRs open against dashboard + each of the repos currently syncing docs to the website. Ideally in future we wouldn't need to make this kind of change in each repo, but the alternative would require changes to the script to detect and modify the frontmatter block inside a HTML comment in a markdown file... This seems like it would be more likely to cause problems so I went with the simpler approach for now. |
/close |
@AlanGreene: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Looks like this is back... #186 (comment) /reopen |
@AlanGreene: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
#187 There is a fix @AlanGreene |
@popcor255 #187 does fix a number of cases of broken links, but as far as I can tell the 'Edit this page' links are a totally different issue. I fixed this originally back in May by adding some config to the frontmatter of the root docs page for each project (see the PRs above) that should be read to determine the project base URL when constructing that link specifically. I'll see if I can figure out why it's broken again... |
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
Stale issues rot after 30d of inactivity. /lifecycle rotten Send feedback to tektoncd/plumbing. |
Rotten issues close after 30d of inactivity. /close Send feedback to tektoncd/plumbing. |
@tekton-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is still an issue, the edit links are broken and we should fix them. |
@AlanGreene: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lifecycle frozen |
Looking at the latest docsy docs I think this could be solved by:
|
This is currently working, the edit links point to the correct location in the repo for the owning project. |
Expected Behavior
Clicking the 'Edit this page' link should bring me to the corresponding file in GitHub.
Actual Behavior
Sub-pages under 'Tasks and Pipelines' and 'Triggers' lead to a 404
Steps to Reproduce the Problem
Additional Info
Sub-pages for Pipelines and Triggers are being synced from the docs folder in their respective repos, so the 'Edit this page' links pointing to the website repo are wrong.
The text was updated successfully, but these errors were encountered: