Update OpenShift pipelines-install instruction… #511
Conversation
tekton-robot
added
the
size/XS
|
@afrittoli @geriom to have this fixed in "versionned" docs of pipeline, what is the process ? 👼🏼 |
| ```bash | ||
| oc apply --filename https://storage.googleapis.com/tekton-releases/pipeline/latest/release.notags.yaml | ||
| curl https://storage.googleapis.com/tekton-releases/pipeline/latest/release.notags.yaml | yq 'del(.spec.template.spec.containers[].securityContext.runAsUser, .spec.template.spec.containers[].securityContext.runAsGroup)' | oc apply -f - |
There was a problem hiding this comment.
Maybe mention explicitly that yq is needed for this, not everyone will have it installed
There was a problem hiding this comment.
or just used sed and don't make yq as deps
curl -s https://storage.googleapis.com/tekton-releases/pipeline/latest/release.notags.yaml|sed '/runAs/d'|kubectl apply -f-
The current documentation doesn't work with OpenShift because of the `securityContext.runAsUser` that comes in the way of the default behavior of OpenShift. This fixes that. Signed-off-by: Vincent Demeester <[email protected]>
vdemeester
force-pushed
the
openshift-pipeline-install-fi
branch
from
abf82ef to
98c8ec6
Compare
Currently we have to wait until the next release for this to work. Maybe we can build the site from HEAD (the site is rebuilt every night) and from there link to both the latest release and the latest LTS release. Thoughts? We also need to come up with a way to preview this kind of content ( tracking this in #493 ) |
|
@geriom what is the status here ? Do we still need to wait for something ? |
|
@vdemeester We can merge this. I'm waiting for someone familiar with OpenShift to approve it. @afrittoli can you take another look please? |
|
Issues go stale after 90d of inactivity. /lifecycle stale Send feedback to tektoncd/plumbing. |
tekton-robot
added
the
lifecycle/stale
|
/remove-lifecycle stale |
tekton-robot
removed
the
lifecycle/stale
|
/lgtm |
|
@piyush-garg: changing LGTM is restricted to collaborators In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: geriom, khrm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Changes
The current documentation doesn't work with OpenShift because of the
securityContext.runAsUserthat comes in the way of the defaultbehavior of OpenShift. This fixes that.
Signed-off-by: Vincent Demeester [email protected]
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide
for more details.