Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field 'isDraft' doesn't exist on type 'PullRequest' #235

Open
HemangLavana opened this issue Oct 22, 2020 · 5 comments
Open

Field 'isDraft' doesn't exist on type 'PullRequest' #235

HemangLavana opened this issue Oct 22, 2020 · 5 comments

Comments

@HemangLavana
Copy link

I am getting the following error message:


run check step: run check step: check: resource script '/opt/resource/check []' failed: exit status 1

stderr:
2020/10/22 14:07:27 check failed: failed to get last commits: Field 'isDraft' doesn't exist on type 'PullRequest'

Our GHE version is: GitHub Enterprise Server 2.20.16. These checks used to work perfectly well, so I believe this failure is due to GHE upgrade. The GHE server is maintained by our IT team so we don't have an option to rollback our GHE.

I suspect this issue is related to:

shurcooL/githubv4#66

Is anyone else seeing this issue and any tips how to workaround this. Our pull-request pipelines are completely broken due to this.

@HemangLavana
Copy link
Author

On further investigation, I found out that:
(a) our GHE was not upgraded recently but few months back,
(b) our pull requests were working until Oct 20th, and
(c) there was a new release of this project (v0.22.0) on Oct 21st.

So I modified my pipeline to explicitly use v0.21.0 and my pipelines have started working again. This looks like a regression bug to me. Let me know if you need any additional details to help resolve this issue.

@rickardl
Copy link
Contributor

It looks like to get this working in GHE, we'd need to implement something to re-write the requests to enable this preview functionality?

@HemangLavana
Copy link
Author

yes, I guess you need to use http.RoundTripper (ex: https://lanre.wtf/blog/2017/07/24/roundtripper-go/). If you need any help in validating the fix, let me know.

@bgandon
Copy link

bgandon commented May 11, 2024

I'd bet upgrading GHE solved the problem. Can we close this issue?

If anything similar appears, it will be sweet to provide feedback to the new maintained repo, thanks!

@bgandon
Copy link

bgandon commented May 11, 2024

@schmurfy maybe?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants