Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The underscore symbol is not recognized as part of the url #250

Open
maxx-bachurin opened this issue Feb 1, 2021 · 1 comment
Open

The underscore symbol is not recognized as part of the url #250

maxx-bachurin opened this issue Feb 1, 2021 · 1 comment

Comments

@maxx-bachurin
Copy link

The resource can't update the status of the pull request if the name of the repo contains underscore. It gives the following error:

put failed: failed to set status: POST https://api.github.com/repos/Test/test-test_test/statuses/73a21b9b4d39386b85c765d117fc3af98f35a82a: 404 Not Found []
@bgandon
Copy link

bgandon commented May 10, 2024

That may be an issue related to GitHub not supporting underscore characters _ in repo names, don't you think?

Anyway, there is no hope that you get any further support here (#246 was 2+y ago).

But recent news is that the Cloud Foundry community is now maintaining a fork of this resource at cloudfoundry-community/github-pr-resource.

On our Concourse installation at Gstack, that one is working fine. Could you give a try and provide feedback there?

(the new resource is a drop-in replacement; you only have to switch telia-ossto cfcommunity in in the resource_types: declaration, i.e. specify repository: cfcommunity/github-pr-resource)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants