Missing PR's

[jdziat]

We're noticing on some of our higher volume repositories that we get occasional missed PR's that never build in concourse. In order to work around this the developers have to push a second commit to trigger the build. It's currently setup to use a webhook trigger as well as the default polling method.

[rosenhouse]

I think I just experienced this as well, where PR A was updated with a force-push to its branch while PR B was opened fresh a couple minutes later. Manually triggering a check on the resource doesn't seem to help.

[jdziat]

@rosenhouse The unfortunate part is the only workaround i can think of is implementing some sort of persistent key value mechanism to track these commits to make sure they're always built. Hopefully i'm missing something fairly obvious though.

[ctreatma]

Based on the description you are likely running up against #26. There are a couple PRs under review that would address that issue, but in the meantime one way to get the resource to notice PRs that it missed is by running the following commands on your PR branch:

git commit --amend --no-edit # Updates commit timestamp without modifying commit contents
git push -f origin head # Force-push your PR branch; proceed with caution so you don't accidentally overwrite something you didn't mean to

[jdziat]

@ctreatma Right, that’s not the best developer experience though.

[bgandon]

Unfortunately, there's no hope that #26 get finished and merged anytime here in this repo (#246 was 2+y ago).

But recent news is that the Cloud Foundry community is now maintaining a fork of this resource at cloudfoundry-community/github-pr-resource.

Especially, the latest version includes a patch for #26.

On our Concourse installation at Gstack, that one is working fine. Could you give a try and provide feedback there?

(the new resource is a drop-in replacement; you only have to switch telia-ossto cfcommunity in in the resource_types: declaration, i.e. specify repository: cfcommunity/github-pr-resource)