Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#816 | change the strategy to only fetch contracts from cache #850

Merged
merged 2 commits into from
Oct 28, 2024
Merged

#816 | change the strategy to only fetch contracts from cache #850

merged 2 commits into from
Oct 28, 2024

Conversation

Viterbo
Copy link
Collaborator

@Viterbo Viterbo commented Sep 6, 2024 •
edited
Loading

Fixes #816

Description

The current implementation has a minimal difference. Now, each time we need to display an address, we take the possible contract metadata from the local cache, delegating to the indexer API the responsibility of populating that cache on each query.

Test Scenarios

You can test this now on the mainnet on the USDT holders page:

@Viterbo Viterbo changed the title 816 rate limiting issue on holders view 2 #816 | change the strategy to only fetch contracts from cache Sep 6, 2024
@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for testnet-teloscan ready!

Name Link
🔨 Latest commit 3f28a9c
🔍 Latest deploy log https://app.netlify.com/sites/testnet-teloscan/deploys/66db09eeaaa0f000080bb8f7
😎 Deploy Preview https://deploy-preview-850--testnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for dev-mainnet-teloscan ready!

Name Link
🔨 Latest commit 3f28a9c
🔍 Latest deploy log https://app.netlify.com/sites/dev-mainnet-teloscan/deploys/66db09ee37a5e100084c785b
😎 Deploy Preview https://deploy-preview-850--dev-mainnet-teloscan.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo linked an issue Sep 6, 2024 that may be closed by this pull request
Rate limiting issue on Holders View #816
Open
@netlify Netlify
Copy link

netlify bot commented Sep 6, 2024 •
edited
Loading

✅ Deploy Preview for teloscan-stage ready!

Name Link
🔨 Latest commit 3f28a9c
🔍 Latest deploy log https://app.netlify.com/sites/teloscan-stage/deploys/66db09ee1b08ab0007967232
😎 Deploy Preview https://deploy-preview-850--teloscan-stage.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Viterbo Viterbo self-assigned this Sep 22, 2024
@Viterbo Viterbo marked this pull request as ready for review September 22, 2024 21:38
@Viterbo Viterbo mentioned this pull request Sep 22, 2024
Closed
@Viterbo Viterbo added the 🚫 Blocked Work cannot be done until blocker is resolved label Sep 24, 2024
@Viterbo Viterbo removed the 🚫 Blocked Work cannot be done until blocker is resolved label Oct 21, 2024
@Viterbo Viterbo requested a review from pmjanus October 21, 2024 14:21
@pmjanus pmjanus merged commit a7e267f into dev Oct 28, 2024
13 checks passed
@pmjanus pmjanus deleted the 816-rate-limiting-issue-on-holders-view-2 branch October 28, 2024 20:14
@pmjanus pmjanus mentioned this pull request Oct 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmjanus pmjanus pmjanus approved these changes

Assignees

@Viterbo Viterbo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rate limiting issue on Holders View
2 participants
@Viterbo @pmjanus