You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The current samples need to have their own prefix, which is basically the last part of the Namespace of the Activity. At least in this setup.
However, if you do not know, that the LocalActivity-Interfaces uses SimpleActivity as a prefix, any change made to the class Temporal\Samples\SimpleActivity\GreetingActivity will not be respected.
<?php/** * This file is part of Temporal package. * * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. */declare(strict_types=1);
namespaceTemporal\Samples\LocalActivity;
useTemporal\Activity\LocalActivityInterface;
useTemporal\Activity\ActivityMethod;
#[LocalActivityInterface(prefix: 'SimpleActivity.')]
interface GreetingActivityInterface
{
#[ActivityMethod(name: "ComposeGreeting")]
publicfunctioncomposeGreeting(
string$greeting,
string$name
): string;
}
Minimal Reproduction
Change any code in the method Temporal\Samples\SimpleActivity\GreetingActivity::composeGreeting().
Ensure that you edited the method in the namespace SimpleActivity!
Reset the worker ./rr reset
Run php app.php simple-activity
You will see that the output comes from Temporal\Samples\LocalActivity\GreetingActivity::composeGreeting()
<?php/** * This file is part of Temporal package. * * For the full copyright and license information, please view the LICENSE * file that was distributed with this source code. */declare(strict_types=1);
namespaceTemporal\Samples\SimpleActivity;
useTemporal\Activity;
// @@@SNIPSTART php-hello-activityclass GreetingActivity implements GreetingActivityInterface
{
publicfunctioncomposeGreeting(string$greeting, string$name): string
{
return$greeting . ' my code changes ' . $name;
}
}
// @@@SNIPEND
Environment/Versions
OS and processor: Macbook Pro M1
This docker-setup
Additional context
The text was updated successfully, but these errors were encountered:
What are you really trying to do?
Describe the bug
The current samples need to have their own prefix, which is basically the last part of the Namespace of the Activity. At least in this setup.
However, if you do not know, that the
LocalActivity
-Interfaces usesSimpleActivity
as aprefix
, any change made to the classTemporal\Samples\SimpleActivity\GreetingActivity
will not be respected.Minimal Reproduction
Temporal\Samples\SimpleActivity\GreetingActivity::composeGreeting()
.SimpleActivity
!./rr reset
php app.php simple-activity
Temporal\Samples\LocalActivity\GreetingActivity::composeGreeting()
Environment/Versions
Additional context
The text was updated successfully, but these errors were encountered: