Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Accept float and int metrics #604

Open
bergundy opened this issue Sep 11, 2023 · 1 comment
Open

[Feature Request] Accept float and int metrics #604

bergundy opened this issue Sep 11, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@bergundy
Copy link
Member

Since our goal with metrics is to expose a generic interface for metrics recording in our lang SDKs using industry standards, we should expand the metrics API in core to accept floats and not just ints.

temporalio/sdk-python#384 (comment)

@cretz
Copy link
Member

cretz commented Sep 18, 2023

Since our goal with metrics is to expose a generic interface for metrics recording in our lang SDKs using industry standards

I am not sure this is a goal. I think it's "expose the same interface core needs". Same in the Go SDK. There are OTel metric types we're not exposing (e.g. up/down counter). Having said that, I don't see why float shouldn't be added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants