Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mogan to v1.2.5.1 (and following LTS) #19608

Closed
Iey4iej3 opened this issue Mar 29, 2024 · 4 comments · Fixed by #19671
Closed

Upgrade mogan to v1.2.5.1 (and following LTS) #19608

Iey4iej3 opened this issue Mar 29, 2024 · 4 comments · Fixed by #19671
Assignees
Labels
has build issues Package compilation fails help wanted Help is wanted in order to solve the issue update package x11 Issue is related to stuff requiring X11 environment or x11-packages

Comments

@Iey4iej3
Copy link

Now mogan has LTS releases XmacsLabs/mogan#1622

I propose to only follow LTS releases (to reduce the effort of maintenance).

The latest LTS is v1.2.5.1, and I propose to upgrade to this version. Moreover, when another point update (e.g. v1.2.5.2) of v1.2.5 is released, I hope that point releases could be followed automatically (e.g. done by a bot), and human intervention is only necessary for major upgrades between different versions of LTS releases.

@truboxl truboxl added help wanted Help is wanted in order to solve the issue update package has build issues Package compilation fails x11 Issue is related to stuff requiring X11 environment or x11-packages labels Mar 30, 2024
@Biswa96
Copy link
Member

Biswa96 commented Mar 30, 2024

I have tired to compile that version but failed after some patching. I do not how to fix the following error.

error: "s7": executable's TLS segment is underaligned: alignment is 8, needs to be at least 64 for ARM64 Bionic
libc: error: "s7": executable's TLS segment is underaligned: alignment is 8, needs to be at least 64 for ARM64 Bionic

The new patches are attached here.

xmake-packages-s7-port-xmake.lua.patch.txt
xmake-packages.lua.patch.txt

Remove src-Scheme-S7-s7.c.patch and xmake.lua.patch files and add libgit2 dependency in build.sh.

@TomJo2000
Copy link
Member

Provided we get the new version to build properly we should also be able to enable auto updates for it.

Thus tracking the mainline releases would be no more work than tracking LTS.

@TomJo2000 TomJo2000 self-assigned this Mar 30, 2024
@Iey4iej3
Copy link
Author

LTS versions are supposed to be stable, and general users are recommended to use LTS versions for the time being, cf. XmacsLabs/mogan#1622 (comment) and XmacsLabs/mogan#1622 (comment)

If you have suggestions which facilitate your maintenance, you could also leave messages there.

@Grimler91
Copy link
Member

I have tired to compile that version but failed after some patching. I do not how to fix the following error.

error: "s7": executable's TLS segment is underaligned: alignment is 8, needs to be at least 64 for ARM64 Bionic
libc: error: "s7": executable's TLS segment is underaligned: alignment is 8, needs to be at least 64 for ARM64 Bionic

termux-elf-cleaner should fix such underalignment: https://github.com/termux/termux-elf-cleaner/blob/5af92859785f773f3d5f30c6d5a1a042844412ab/elf-cleaner.cpp#L108-L122

@TomJo2000 TomJo2000 removed their assignment Apr 1, 2024
@truboxl truboxl self-assigned this Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has build issues Package compilation fails help wanted Help is wanted in order to solve the issue update package x11 Issue is related to stuff requiring X11 environment or x11-packages
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants