feat: Add support for EBS GP3 throughput #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. Please fix formatting by running |
antonbabenko
changed the title
|
Pre-commit hooks run and all clear ! |
|
Ok, I fixed the docs. You used to use terraform-docs v0.13.0. |
|
v2.21.0 has been just released. |
|
Perfect thanks a lot ! |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #226
Description
Added the mapping of throughput in the dynamic root block and ebs block device objects
Motivation and Context
This will allow to provision gp3 volumes with the capacity to define the required throughput
Breaking Changes
No breaking changes foreseen.
I did not implement checks on volume type since the AWS API will error out in case this is specified for a non gp3 ebs volume.
How Has This Been Tested?
examples/*projectsI have changed the basic example to have it deploy gp3 volumes for the root and also for additional ebs and also included throughtput values.
I have also tested a case where user input is incorrect ie setting volume type to gp2 and setting the throughput.
=> AWS API error is clear enough to guide the end user to correct his/her inputs :
Error: error collecting instance settings: error creating resource: throughput attribute not supported for ebs_block_device with volume_type gp2
Please feel free to provide your feedback I'd be happy to take it into account.
Thanks.
Bests.