Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Network Interface ID Removal #75

Closed
pnduati opened this issue Feb 28, 2019 · 5 comments
Closed

Network Interface ID Removal #75

pnduati opened this issue Feb 28, 2019 · 5 comments

Comments

@pnduati
Copy link
Contributor

pnduati commented Feb 28, 2019

local.this_network_interface_id: Resource 'aws_instance.this_t2' does not have attribute 'network_interface_id' for variable 'aws_instance.this_t2.*.network_interface_id'
@antonbabenko @den-is

@pnduati pnduati changed the title Network Interface ID Attribute Network Interface ID Removal Feb 28, 2019
@danielwrayois
Copy link

danielwrayois commented Feb 28, 2019

Hi,

This is likely to be related to the AWS 2.0 provider released yesterday by Hashicorp. If you aren't pinning your version to the AWS 1.60 provider you should do this until the issue is resolved in this module.

I believe the proper fix is to rename the network_interface_id parameter to primary_network_interface_id.

@antonbabenko
Copy link
Member

@pnduati Could you switch to primary_network_interface_id in #76 and I will merge that PR. This change will make this module 2.0.0-ready.

@pnduati
Copy link
Contributor Author

pnduati commented Feb 28, 2019

@antonbabenko @danielwrayois We already have primary_network_interface_id parameter in the outputs definition. The PR removes the network_interface_id, cause this is deprecated.

@antonbabenko
Copy link
Member

You are right, thanks for this fix.

v1.19.0 has been released.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants