Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'dns_name' attribute to aws_efs_file_system resource #1825

Merged
merged 1 commit into from
Oct 9, 2017

Conversation

alewando
Copy link
Contributor

@alewando alewando commented Oct 5, 2017

This adds a 'dns_name' attribute to the aws_efs_file_system resource, reflecting the AZ-agnostic naming convention described in AWS docs. A similar change was made to aws_efs_mount_target and this PR mimics that change at the filesystem level. Technically, I think the change to aws_efs_mount_target was incorrect, since the AZ-specific names that terraform was generating for mount targets are still valid and there is now no way to get them. I did not undo that change here, however, since I imagine some users are relying on it. In any case, getting a AZ-agnostic DNS name (useable anywhere in the VPC) seems more natural coming from the filesystem itself than from an AZ-specific mount target.

See hashicorp/terraform#10902 and hashicorp/terraform#11023

Copy link
Member

@radeksimko radeksimko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM. I think we can keep the dns_name in mount target - I can see it being useful for users which manage FS separately from MTs and for compatibility reasons.

@radeksimko radeksimko added the enhancement Requests to existing resources that expand the functionality or scope. label Oct 9, 2017
@radeksimko radeksimko merged commit 227d68f into hashicorp:master Oct 9, 2017
@ghost
Copy link

ghost commented Apr 11, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Requests to existing resources that expand the functionality or scope.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants