Add 'dns_name' attribute to aws_efs_file_system resource #1825
+21
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a 'dns_name' attribute to the aws_efs_file_system resource, reflecting the AZ-agnostic naming convention described in AWS docs. A similar change was made to aws_efs_mount_target and this PR mimics that change at the filesystem level. Technically, I think the change to aws_efs_mount_target was incorrect, since the AZ-specific names that terraform was generating for mount targets are still valid and there is now no way to get them. I did not undo that change here, however, since I imagine some users are relying on it. In any case, getting a AZ-agnostic DNS name (useable anywhere in the VPC) seems more natural coming from the filesystem itself than from an AZ-specific mount target.
See hashicorp/terraform#10902 and hashicorp/terraform#11023