Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r/redshift_cluster: Make snapshot identifiers ForceNew #2212

Merged
merged 1 commit into from
Nov 8, 2017

Conversation

radeksimko
Copy link
Member

@radeksimko radeksimko commented Nov 8, 2017

None of those two are mutable per docs, or to be more precise they're only valid during the creation of of the cluster.

In order to test this we'd need to spin up a separate cluster, take a snapshot, destroy it, pass it to a test, then delete the test cluster and delete the snapshot which may all take a couple of hours, so I'm not sure if it's worth it for such a simple (and IMO fairly obvious) change.

@radeksimko radeksimko added the bug Addresses a defect in current functionality. label Nov 8, 2017
@radeksimko radeksimko requested a review from catsby November 8, 2017 11:39
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- agreed about the testing

Copy link
Contributor

@catsby catsby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable 👍

@radeksimko radeksimko merged commit 465ab73 into master Nov 8, 2017
@radeksimko radeksimko deleted the b-redshift-snapshot-forcenew branch November 8, 2017 16:51
@ghost
Copy link

ghost commented Apr 10, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants