add create_date as an attribute to aws_iam_instance_profile resource #4932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bflad
added
enhancement
bflad
reviewed
Jun 21, 2018
| @@ -307,6 +307,9 @@ func instanceProfileReadResult(d *schema.ResourceData, result *iam.InstanceProfi | |||
| if err := d.Set("arn", result.Arn); err != nil { | |||
| return err | |||
| } | |||
| if err := d.Set("create_date", result.CreateDate); err != nil { | |||
There was a problem hiding this comment.
@bootswithdefer the *time.Time value needs to be turned into a string:
=== RUN TestAccAWSIAMInstanceProfile_basic
--- FAIL: TestAccAWSIAMInstanceProfile_basic (4.90s)
testing.go:518: Step 0 error: Error applying: 1 error(s) occurred:
* aws_iam_instance_profile.test: 1 error(s) occurred:
* aws_iam_instance_profile.test: Error creating IAM instance profile test: create_date: '' expected type 'string', got unconvertible type '*time.Time'
e.g. result.CreateDate.Format(time.RFC3339)
bootswithdefer
force-pushed
the
instance-profile-create-date
branch
from
17eaa86 to
f4be339
Compare
|
Fixed. Also got my acceptance testing environment set up. |
bflad
approved these changes
Jun 22, 2018
There was a problem hiding this comment.
Looks great @bootswithdefer! 🚀
(For those curious about such the small change, the attribute was already defined in the schema and in the documentation)
5 tests passed (all tests)
=== RUN TestAccAWSIAMInstanceProfile_missingRoleThrowsError
--- PASS: TestAccAWSIAMInstanceProfile_missingRoleThrowsError (2.71s)
=== RUN TestAccAWSIAMInstanceProfile_basic
--- PASS: TestAccAWSIAMInstanceProfile_basic (11.23s)
=== RUN TestAccAWSIAMInstanceProfile_withRoleNotRoles
--- PASS: TestAccAWSIAMInstanceProfile_withRoleNotRoles (11.53s)
=== RUN TestAccAWSIAMInstanceProfile_namePrefix
--- PASS: TestAccAWSIAMInstanceProfile_namePrefix (12.00s)
=== RUN TestAccAWSIAMInstanceProfile_importBasic
--- PASS: TestAccAWSIAMInstanceProfile_importBasic (12.75s)
bflad
added a commit
that referenced
this pull request
Jun 22, 2018
|
This has been released in version 1.25.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. |
|
I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks! |
ghost
locked and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3527
Changes proposed in this pull request:
Acceptance testing not run. Manually tested on an existing instance profile in my environment.