Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource/aws_codebuild_project: Add arn attribute and improve id attribute documentation #5973

Merged
merged 1 commit into from
Sep 26, 2018

Conversation

bflad
Copy link
Contributor

@bflad bflad commented Sep 24, 2018

Closes #5962

Changes proposed in this pull request:

  • Add arn attribute to aws_codebuild_project
  • Document id attribute behavior better

Output from acceptance testing:

23 tests passed (all tests)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodePipeline (17.08s)
--- PASS: TestAccAWSCodeBuildProject_WindowsContainer (17.28s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_CodeCommit (17.61s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_S3 (17.96s)
--- PASS: TestAccAWSCodeBuildProject_importBasic (18.01s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_Bitbucket (18.10s)
--- PASS: TestAccAWSCodeBuildProject_Source_InsecureSSL (21.74s)
--- PASS: TestAccAWSCodeBuildProject_basic (25.83s)
--- PASS: TestAccAWSCodeBuildProject_BadgeEnabled (25.84s)
--- PASS: TestAccAWSCodeBuildProject_Source_Type_GitHubEnterprise (26.01s)
--- PASS: TestAccAWSCodeBuildProject_Source_Auth (25.99s)
--- PASS: TestAccAWSCodeBuildProject_Tags (29.55s)
--- PASS: TestAccAWSCodeBuildProject_Source_GitCloneDepth (29.68s)
--- PASS: TestAccAWSCodeBuildProject_Source_ReportBuildStatus (29.83s)
--- PASS: TestAccAWSCodeBuildProject_Description (30.14s)
--- PASS: TestAccAWSCodeBuildProject_Environment_EnvironmentVariable_Type (30.12s)
--- PASS: TestAccAWSCodeBuildProject_BuildTimeout (30.58s)
--- PASS: TestAccAWSCodeBuildProject_EncryptionKey (35.23s)
--- PASS: TestAccAWSCodeBuildProject_VpcConfig (37.10s)
--- PASS: TestAccAWSCodeBuildProject_Artifacts_EncryptionDisabled (24.02s)
--- PASS: TestAccAWSCodeBuildProject_SecondaryArtifacts (23.97s)
--- PASS: TestAccAWSCodeBuildProject_SecondarySources_CodeCommit (23.68s)
--- PASS: TestAccAWSCodeBuildProject_Cache (43.49s)

@bflad bflad added enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. labels Sep 24, 2018
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. documentation Introduces or discusses updates to documentation. service/codebuild Issues and PRs that pertain to the codebuild service. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure. labels Sep 24, 2018
@bflad bflad requested a review from a team September 24, 2018 21:33
@bflad bflad mentioned this pull request Sep 24, 2018
@bflad bflad added this to the v1.38.0 milestone Sep 26, 2018
@bflad bflad merged commit c0270cc into master Sep 26, 2018
@bflad bflad deleted the f-aws_codebuild_project-arn branch September 26, 2018 19:23
bflad added a commit that referenced this pull request Sep 26, 2018
@bflad
Copy link
Contributor Author

bflad commented Sep 26, 2018

This has been released in version 1.38.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Apr 3, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Apr 3, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Introduces or discusses updates to documentation. enhancement Requests to existing resources that expand the functionality or scope. service/codebuild Issues and PRs that pertain to the codebuild service. size/XS Managed by automation to categorize the size of a PR. tests PRs: expanded test coverage. Issues: expanded coverage, enhancements to test infrastructure.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS CodeBuild Project ARN
2 participants