Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #7417 aws_ec2_transit_gateway_vpc_attachment error when auto_ac… #7489

Merged
merged 1 commit into from
Feb 12, 2019

Conversation

saravanan30erd
Copy link
Contributor

…cept_shared_attachments is disabled

Fixes #7417

Changes proposed in this pull request:

  • Change 1
    Included the pendingAcceptance as one of the Target value for resource creation.

…n auto_accept_shared_attachments is disabled
@ghost ghost added size/XS Managed by automation to categorize the size of a PR. service/ec2 Issues and PRs that pertain to the ec2 service. labels Feb 9, 2019
@bflad bflad added the bug Addresses a defect in current functionality. label Feb 12, 2019
@bflad bflad added this to the v1.59.0 milestone Feb 12, 2019
Copy link
Contributor

@bflad bflad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this fix and using the SDK constant, @saravanan30erd! 🚀 We currently do not have the acceptance testing framework setup for multi-account RAM testing yet, so approving based on the potential automated workflow in Terraform in the future.

@bflad bflad merged commit 87a155f into hashicorp:master Feb 12, 2019
bflad added a commit that referenced this pull request Feb 12, 2019
@saravanan30erd saravanan30erd deleted the issue-7417 branch February 14, 2019 23:50
@bflad
Copy link
Contributor

bflad commented Feb 14, 2019

This has been released in version 1.59.0 of the AWS provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

@ghost
Copy link

ghost commented Mar 31, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. Thanks!

@ghost ghost locked and limited conversation to collaborators Mar 31, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Addresses a defect in current functionality. service/ec2 Issues and PRs that pertain to the ec2 service. size/XS Managed by automation to categorize the size of a PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aws_ec2_transit_gateway_vpc_attachment error when auto_accept_shared_attachments = disable
2 participants