Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Traffic manager TTL can be 1 second #3632

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Traffic manager TTL can be 1 second #3632

merged 1 commit into from
Jun 12, 2019

Conversation

NillsF
Copy link
Contributor

@NillsF NillsF commented Jun 10, 2019

Traffic manager TTL can actually be 1 second.

@ghost ghost added the size/XS label Jun 10, 2019
Copy link
Collaborator

@katbyte katbyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this change @NillsF,

could you modify or create a new test to confirm this? thanks!

Copy link
Contributor

@tombuildsstuff tombuildsstuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @NillsF

Thanks for this PR - taking a look in the portal I can confirm this value so I think this is good to merge 👍

Thanks!

@tombuildsstuff tombuildsstuff dismissed katbyte’s stale review June 12, 2019 07:18

dismissing since this has been validated in the portal

@tombuildsstuff tombuildsstuff merged commit 4937f72 into hashicorp:master Jun 12, 2019
@tombuildsstuff tombuildsstuff added this to the v1.31.0 milestone Jun 12, 2019
tombuildsstuff added a commit that referenced this pull request Jun 12, 2019
@ghost
Copy link

ghost commented Jun 28, 2019

This has been released in version 1.31.0 of the provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. As an example:

provider "azurerm" {
    version = "~> 1.31.0"
}
# ... other configuration ...

@ghost
Copy link

ghost commented Jul 12, 2019

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you feel this issue should be reopened, we encourage creating a new issue linking back to this one for added context. If you feel I made an error 🤖 🙉 , please reach out to my human friends 👉 [email protected]. Thanks!

@ghost ghost locked and limited conversation to collaborators Jul 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants