add handling for winrm communicator in username & password handling #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ah i see where i need to update the tests. will do. |
added 2 commits
April 14, 2015 13:53
… because communicator: isn't always set and (apparently) doesn't default to something
…cope if a communicator is set., if no communicator is set ssh is assumed add spec test for username and password communicator scope if communicator is set
|
Thank you, and thanks for the added tests!
|
fnichol
added a commit
that referenced
this pull request
May 7, 2015
Add handling for winrm communicator in username & password handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fixes winrm out of the box. before change c.vm.communicator would be set to winrm correctly but username and password would be prefixed with c.ssh. also add handling for additional winrm config settings