You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I discovered an issue with testcontainers-solr if used with the latest released version of Solr 0.9.7. The SolrContainer class hardcodes startup parameters, which have changed with the latest release. Instead of accepting -h or -host, the script now only accepts --host.
This change is not backwards-compatible. The best possible solution I can think of is to compare the image tag to determine if the image being used is prior to the change or not and use the correct command line option.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Hi All
I discovered an issue with
testcontainers-solr
if used with the latest released version of Solr 0.9.7. TheSolrContainer
class hardcodes startup parameters, which have changed with the latest release. Instead of accepting-h
or-host
, the script now only accepts--host
.https://github.com/molnarp/testcontainers-java/blob/77a423c812ad044c0a2076b7495eb298eb72f85b/modules/solr/src/main/java/org/testcontainers/containers/SolrContainer.java#L117
apache/solr@0df3e63#diff-49c29c8f653341f48008c38f5f2cf970fa430cdca29181c819d7bdcfcc722980R379
This change is not backwards-compatible. The best possible solution I can think of is to compare the image tag to determine if the image being used is prior to the change or not and use the correct command line option.
What do you think?
Beta Was this translation helpful? Give feedback.
All reactions