Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please pass JDBC driver info properties back to original database driver #1339

Closed
ajdergute opened this issue Mar 25, 2019 · 3 comments
Closed
Labels

Comments

@ajdergute
Copy link

ajdergute commented Mar 25, 2019

It might be nesseccary to pass additional properties to the original database driver, i.e. "user" and "password". To enforce this please add an additional argument Properties to JdbcDatabaseContainer#createConnection as follows:

public Connection createConnection(String queryString, Properties info) throws SQLException {

in addition to that, please traf user and password from this argument if given.

If done, please pass the info object given by

public synchronized Connection connect(String url, Properties info) throws SQLException {

to the createConnection call.

This should also ensure that one is able to use multiple users while testing the database. E.g. for multi tenancy via view or database approach.

@ajdergute
Copy link
Author

The main point of this issue is covered with: #1293

I'll test if this fits my use case.

Anyway, there might be other JDBC options, e.g. for TLS to pass to the underlying database. Therefore it might be nice to pass through all options from the given Url.

@stale
Copy link

stale bot commented Jun 29, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Jun 29, 2019
@stale
Copy link

stale bot commented Jul 13, 2019

This issue has been automatically closed due to inactivity. We apologise if this is still an active problem for you, and would ask you to re-open the issue if this is the case.

@stale stale bot closed this as completed Jul 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant