Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow mysql customizations #354

Closed

Conversation

nickbabcock
Copy link
Contributor

This is #220 but for maria and mysql

@bsideup
Copy link
Member

bsideup commented Jun 10, 2017

Hi @nickbabcock,

We just moved MariaDB to a separate repo:
https://github.com/testcontainers/testcontainers-java-module-mariadb

Any chance you can submit it there? :) Sorry about that :)

@nickbabcock nickbabcock changed the title Allow mysql and mariadb customizations Allow mysql customizations Jun 12, 2017
@nickbabcock
Copy link
Contributor Author

nickbabcock commented Jun 12, 2017

Ok removed all mention and code related to mariadb from this PR.

I'll submit the mariadb PR shortly

@bsideup
Copy link
Member

bsideup commented Jun 12, 2017

@nickbabcock I just think what if we move this to JDBCContainer so that every JDBC-based implementation will receive this functionality?

@nickbabcock
Copy link
Contributor Author

nickbabcock commented Jun 12, 2017

Are you talking about adding abstract with methods to JdbcDatabaseContainer? Outside of them being environment variables, I can't see a a common way for setting these parameters across db containers.

EDIT: And I wouldn't know how to implement those methods for oracle-xe, as the docker page doesn't go into depth.

@kiview
Copy link
Member

kiview commented Jun 23, 2017

I prefer @bsideup's idea as well, using an abstract with method as you proposed. For those database who don't yet have this functionality and for which you don't know how to implement it right now, we could throw a UnsupportedOperationException and create an issue to support this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants